goreplay-cli package #1148
goreplay-cli package #1148
Conversation
| @@ -266,7 +265,7 @@ func init() { | |||
|
|
|||
| } | |||
|
|
|||
| func checkSettings() { | |||
| func CheckSettings() { | |||
There was a problem hiding this comment.
exported function CheckSettings should have comment or be unexported
| @@ -266,7 +265,7 @@ func init() { | |||
|
|
|||
| } | |||
|
|
|||
| func checkSettings() { | |||
| func CheckSettings() { | |||
There was a problem hiding this comment.
exported function CheckSettings should have comment or be unexported
| @@ -266,7 +265,7 @@ func init() { | |||
|
|
|||
| } | |||
|
|
|||
| func checkSettings() { | |||
| func CheckSettings() { | |||
There was a problem hiding this comment.
exported function CheckSettings should have comment or be unexported
|
That's for sure interesting! However you made some of really useful packages internal, and if we talking about writing some "go plugins" in future, having |
I guess the |
|
I see, makes sense. If in future it will be needed, most likely it will be needed indirectly by exposing more human friendly interface. in this case lets make "proto" package open, and we can merge. |
done |
DimaGolomozy
force-pushed
the
goreplay-cli
branch
from
d9097d0 to
45c8a8d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looks good! |
change package from
main -> goreplaythis will allow importing
goreplayas a package@buger wdyt?