Skip to content

Audit whether slicesext.ToStructMapOmitEmpty can be removed #3828

Open
@bufdev

Description

@bufdev

We have a note on slicesext.ToStructMapOmitEmpty:

// TODO FUTURE: Make ToStructMap use this logic, remove ToStructMapOmitEmpty, to match other functions.

We likely did this to make sure we didn't edit existing behavior, but I bet if we go through buf and core, we won't find anywhere that relies on the zero value being populated as a key. We just need to do this audit, and if so, delete the existing ToStructMap and rename ToStructMapOmitEmpty to ToStructMap.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions