Skip to content

Commit b442e4e

Browse files
authored
Enable row references and force Brainstore as default (#74)
* Switch BRAINSTORE_DEFAULT to force There shouldn't be any more TF users on clickhouse * BRAINSTORE_INSERT_ROW_REFS is always on now
1 parent 3b8a07d commit b442e4e

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

modules/services/lambda-apihandler.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ resource "aws_lambda_function" "api_handler" {
6969
BRAINSTORE_REALTIME_WAL_BUCKET = local.brainstore_s3_bucket
7070
BRAINSTORE_ENABLE_HISTORICAL_FULL_BACKFILL = var.brainstore_enable_historical_full_backfill
7171
BRAINSTORE_BACKFILL_NEW_OBJECTS = var.brainstore_backfill_new_objects
72+
BRAINSTORE_INSERT_ROW_REFS = "true"
7273

7374
CLICKHOUSE_PG_URL = local.clickhouse_pg_url
7475
CLICKHOUSE_CONNECT_URL = local.clickhouse_connect_url

modules/services/variables.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,10 +230,10 @@ variable "brainstore_etl_batch_size" {
230230
variable "brainstore_default" {
231231
type = string
232232
description = "Whether to set Brainstore as the default rather than requiring users to opt-in via feature flag."
233-
default = "true"
233+
default = "force"
234234
validation {
235-
condition = contains(["true", "false", "forced"], var.brainstore_default)
236-
error_message = "brainstore_default must be true, false, or forced."
235+
condition = contains(["true", "false", "force"], var.brainstore_default)
236+
error_message = "brainstore_default must be true, false, or force."
237237
}
238238
}
239239

variables.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,10 +280,10 @@ variable "enable_brainstore" {
280280
variable "brainstore_default" {
281281
type = string
282282
description = "Whether to set Brainstore as the default rather than requiring users to opt-in via feature flag. Don't set this if you have a large backfill ongoing and are migrating from Clickhouse."
283-
default = "true"
283+
default = "force"
284284
validation {
285-
condition = contains(["true", "false", "forced"], var.brainstore_default)
286-
error_message = "brainstore_default must be true, false, or forced."
285+
condition = contains(["true", "false", "force"], var.brainstore_default)
286+
error_message = "brainstore_default must be true, false, or force."
287287
}
288288
}
289289

0 commit comments

Comments
 (0)