Tweak provider error message #248
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ibolmo
reviewed
Jun 10, 2025
| @@ -1139,7 +1139,7 @@ async function fetchModelLoop( | |||
| headersString.push(`${key}: ${value}`); | |||
| }); | |||
| const errorText = | |||
| `AI provider returned ${httpCode} error.\n\nHeaders:\n` + | |||
| `The AI provider returned ${httpCode} error. This is likely not an issue with Braintrust, but rather with the model provider.${httpCode === 500 ? " Please check the model provider's status page." : httpCode === 429 ? " Please adjust max concurrency." : ""}\n\nHeaders:\n` + | |||
There was a problem hiding this comment.
The "please adjust concurrency" is throwing me off. Is that on the Braintrust side (i.e. playground concurrency) or is that like a quota/limit problem in the AI provider?
You may consider just dropping this one and keep the rest. I think most folks know what 429 is.
Would you see us return the statusText and/or response.text() in addition to headers?
There was a problem hiding this comment.
I'm also curious if we shouldn't return a JSON message rather than a plain message. This way we avoid losing fidelity.
ibolmo
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.