Skip to content

Commit d761fb0

Browse files
committed
More clean up
1 parent a908fe8 commit d761fb0

File tree

4 files changed

+8
-14
lines changed

4 files changed

+8
-14
lines changed

kotlin/internal/jvm/impl.bzl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,6 @@ def _write_launcher_action(ctx, rjars, main_class, jvm_flags):
137137
)
138138
return []
139139

140-
# Exposed for kt_android_* rules
141-
write_launcher_action_exposed = _write_launcher_action
142-
143140
# buildifier: disable=unused-variable
144141
def _is_source_jar_stub(jar):
145142
"""Workaround for intellij plugin expecting a source jar"""

kotlin/internal/jvm/jvm.bzl

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -661,9 +661,7 @@ kt_plugin_cfg = rule(
661661
},
662662
)
663663

664-
#
665-
# Exposed for kt_android_* rules.
666-
#
667-
lib_common_attr_exposed = _lib_common_attr
668-
runnable_common_attr_exposed = _runnable_common_attr
669-
common_outputs_exposed = _common_outputs
664+
attrs = struct(
665+
lib_common_attr = _lib_common_attr,
666+
runnable_common_attr = _runnable_common_attr,
667+
)

kotlin/internal/jvm/kt_android_library.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ load(
2626
)
2727
load(
2828
"//kotlin/internal/jvm:jvm.bzl",
29-
_lib_common_attr_exposed = "lib_common_attr_exposed",
29+
_attrs = "attrs",
3030
)
3131
load(
3232
"//kotlin/internal/jvm:kt_android_library_impl.bzl",
@@ -37,7 +37,7 @@ load(
3737
_utils = "utils",
3838
)
3939

40-
_ATTRS = _utils.add_dicts(_BASE_ATTRS, _lib_common_attr_exposed, {
40+
_ATTRS = _utils.add_dicts(_BASE_ATTRS, _attrs.lib_common_attr, {
4141
})
4242

4343
kt_android_library = _make_rule(

kotlin/internal/jvm/kt_android_local_test.bzl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ load(
2828
)
2929
load(
3030
"//kotlin/internal/jvm:jvm.bzl",
31-
_lib_common_attr_exposed = "lib_common_attr_exposed",
32-
_runnable_common_attr_exposed = "runnable_common_attr_exposed",
31+
_attrs = "attrs",
3332
)
3433
load(
3534
"//kotlin/internal/jvm:kt_android_local_test_impl.bzl",
@@ -40,7 +39,7 @@ load(
4039
_utils = "utils",
4140
)
4241

43-
_ATTRS = _utils.add_dicts(_BASE_ATTRS, _runnable_common_attr_exposed, {
42+
_ATTRS = _utils.add_dicts(_BASE_ATTRS, _attrs.runnable_common_attr, {
4443
"main_class": attr.string(default = "com.google.testing.junit.runner.BazelTestRunner"),
4544
"jacocorunner": attr.label(
4645
default = Label("@bazel_tools//tools/jdk:JacocoCoverage"),

0 commit comments

Comments
 (0)