Improve part of the output of --toolchain_resolution_debug
#26037
+146
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
improve-toolchain-resolution-output
branch
from
52f3180 to
61d1bac
Compare
github-actions
bot
added
the
awaiting-review
|
@katre @gregestren Please let me know what you think of the new output format. If you like it, I will update the tests. |
fmeum
changed the title
--toolchain_resolution_debug--toolchain_resolution_debug
katre
suggested changes
May 9, 2025
| /** Report on which toolchains were selected. */ | ||
| void reportSelectedToolchains( | ||
| void startDebugging( | ||
| EventHandler eventHandler, |
There was a problem hiding this comment.
Since the eventHandler ultimately comes from the SkyFunction.Environment, why not save it during the create call? Why pass it to every method? Are the instances changing?
There was a problem hiding this comment.
Yes, there is a check in Skyframe that specifically guards against this.
katre
suggested changes
May 9, 2025
iancha1992
added
the
team-Configurability
satyanandak
added
awaiting-user-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the debug output of
ToolchainResolutionFunction(but notSingleToolchainResolutionFunction) in several ways:A preexisting problem that hasn't been fixed is that messages about rejected or removed execution platforms is interleaved with other output and thus can't easily be linked to the start/finish messages. How to resolve this in the context of Skyframe restarts and messages printed by the "child" SkyFunction
SingleToolchainResolutionFunctionremains an open problem.Work towards #11984