Skip to content

Set --combined_report to lcov by default #26328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 18, 2025

It's very likely that someone running bazel coverage wants a combined report and the message announcing the report's path makes the effect of bazel coverage easier to understand.

RELNOTES[INC]: --combined_report now defaults to lcov (was: none).

It's very likely that someone running `bazel coverage` wants a combined report and the message announcing the report's path makes the effect of `bazel coverage` easier to understand.

RELNOTES[INC]: `--combined_report` now defaults to `lcov` (was: `none`).
@fmeum fmeum requested a review from c-mita June 18, 2025 10:54
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 18, 2025

@c-mita This should be merged after #26329.

@fmeum fmeum marked this pull request as ready for review June 18, 2025 10:54
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 18, 2025
Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine; it's rarely desirable to not set this and baseline coverage now requires it.

@c-mita c-mita added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 18, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 18, 2025
@fmeum fmeum deleted the flip-combined-report branch June 18, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants