Delete a redundant method

PiperOrigin-RevId: 792537906
Change-Id: Ifb0346c2bc9955796f9c74cca1ab881788105919

Author: hvadehra

src/test/java/com/google/devtools/build/lib/rules/cpp/BUILD

@@ -50,16 +50,14 @@ java_library(
         "LinkBuildVariablesTestCase.java",
     ],
     deps = [
+        ":CcToolchainTestHelper",
         "//src/main/java/com/google/devtools/build/lib/actions:artifacts",
         "//src/main/java/com/google/devtools/build/lib/analysis:analysis_cluster",
         "//src/main/java/com/google/devtools/build/lib/analysis:configured_target",
         "//src/main/java/com/google/devtools/build/lib/rules/cpp",
-        "//src/main/java/com/google/devtools/build/lib/vfs:pathfragment",
-        "//src/main/protobuf:crosstool_config_java_proto",
         "//src/test/java/com/google/devtools/build/lib/analysis/util",
         "//third_party:guava",
         "//third_party:truth",
-        "@com_google_protobuf//:protobuf_java",
     ],
 )
 

src/test/java/com/google/devtools/build/lib/rules/cpp/LinkBuildVariablesTestCase.java

@@ -16,7 +16,6 @@
 
 import static com.google.common.truth.Truth.assertThat;
 
-import com.google.common.base.Joiner;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Iterables;
 import com.google.devtools.build.lib.actions.Artifact;
@@ -25,9 +24,6 @@
 import com.google.devtools.build.lib.analysis.actions.SpawnAction;
 import com.google.devtools.build.lib.analysis.util.BuildViewTestCase;
 import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.FeatureConfiguration;
-import com.google.devtools.build.lib.vfs.PathFragment;
-import com.google.devtools.build.lib.view.config.crosstool.CrosstoolConfig.CToolchain;
-import com.google.protobuf.TextFormat;
 import java.util.List;
 
 /**
@@ -119,22 +115,11 @@ protected CcToolchainVariables getLinkBuildVariables(
     return getLinkCommandLine(getCppLinkAction(target, type)).getBuildVariables();
   }
 
-  /** Creates a CcToolchainFeatures from features described in the given toolchain fragment. */
-  public static CcToolchainFeatures buildFeatures(RuleContext ruleContext, String... toolchain)
-      throws Exception {
-    CToolchain.Builder toolchainBuilder = CToolchain.newBuilder();
-    TextFormat.merge(Joiner.on("").join(toolchain), toolchainBuilder);
-    return new CcToolchainFeatures(
-        CcToolchainConfigInfo.fromToolchainForTestingOnly(toolchainBuilder.buildPartial()),
-        /* ccToolchainPath= */ PathFragment.EMPTY_FRAGMENT);
-  }
-
   /** Returns the value of a given sequence variable in context of the given Variables instance. */
   protected static List<String> getSequenceVariableValue(
       RuleContext ruleContext, CcToolchainVariables variables, String variable) throws Exception {
     FeatureConfiguration mockFeatureConfiguration =
-        buildFeatures(
-                ruleContext,
+        CcToolchainTestHelper.buildFeatures(
                 "feature {",
                 "  name: 'a'",
                 "  flag_set {",
@@ -153,8 +138,7 @@ protected static List<String> getSequenceVariableValue(
   protected static String getVariableValue(
       RuleContext ruleContext, CcToolchainVariables variables, String variable) throws Exception {
     FeatureConfiguration mockFeatureConfiguration =
-        buildFeatures(
-                ruleContext,
+        CcToolchainTestHelper.buildFeatures(
                 "feature {",
                 "  name: 'a'",
                 "  flag_set {",