[Bug]: Attachment download is not working

[abrardev99]

What happened?

Attachment downloading is not working, and getting the file does not exist

You can see file does exist

If I change the implementation to the following, it starts working fine.

return Storage::download($file, $filename, [
    'Content-Type' => $attachment->mime,
]);

Looks like response()->download is not working as expected.

I'm not sure if it's really a bug. Open to your thoughts and suggestions.

How to reproduce the bug

1. Configure MinIO locally or use s3 for storage.
2. Send an email with an attachment nt
3. Try to download the attachment from the Filament resource.

Package Version

2.3.6

PHP Version

8.3

Laravel Version

11

Which operating systems does with happen with?

macOS

Notes

No response

[markvaneijk]

@abrardev99 can run composer update to check if the new version solves your issue? If not, please post the database row of the mail attachment and your filesystems config.

[abrardev99]

@abrardev99 can run composer update to check if the new version solves your issue? If not, please post the database row of the mail attachment and your filesystems config.

I ran composer update and its still not working.

here is the database row of mail attachment

And here is my filesystem config.

<?php

return [

    'disks' => [
        's3-public' => [
            'driver' => 's3',
            'key' => env('AWS_ACCESS_KEY_ID'),
            'secret' => env('AWS_SECRET_ACCESS_KEY'),
            'region' => env('AWS_DEFAULT_REGION'),
            'bucket' => env('AWS_BUCKET_PUBLIC'),
            'url' => env('AWS_URL'),
            'endpoint' => env('AWS_ENDPOINT'),
            'use_path_style_endpoint' => env('AWS_USE_PATH_STYLE_ENDPOINT', false),
            'throw' => false,
        ],

        's3-browsershot' => [
            'driver' => 's3',
            'key' => env('AWS_ACCESS_KEY_ID'),
            'secret' => env('AWS_SECRET_ACCESS_KEY'),
            'region' => env('SIDECAR_REGION'),
            'bucket' => env('AWS_BR_BUCKET_PUBLIC'),
            'url' => env('AWS_URL'),
            'endpoint' => env('AWS_ENDPOINT'),
            'use_path_style_endpoint' => env('AWS_USE_PATH_STYLE_ENDPOINT', false),
            'throw' => false,
        ],
    ],

];

I have customized the storagePath in the MailAttachment model which looks like below

<?php

namespace App\Models;

class MailAttachment extends \Vormkracht10\Mails\Models\MailAttachment
{
    public function getStoragePathAttribute(): string
    {
        $tenantId = $this->mail->tenant_id ?? null;
        if ($tenantId) {
            return rtrim(config('mails.logging.attachments.root'), '/') . '/' . $tenantId . '/' . $this->getKey() . '/' . $this->filename;
        }

        return rtrim(config('mails.logging.attachments.root'), '/') . '/' . $this->getKey() . '/' . $this->filename;
    }
}