🐛 Fix one-line conditional

matching for 'not None' instead of positive value 🙈

Author: azogue

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [v4.2.1](https://github.com/azogue/aiopvpc/tree/v4.2.1) - Fix injection price sensor attributes (2) (2023-05-29)
+
+[Full Changelog](https://github.com/azogue/aiopvpc/compare/v4.2.0...v4.2.1)
+
+- 🐛 Fix one-line conditional matching for 'not None' instead of positive value 🙈
+- ✅ tests: Add unit test for price sensor attributes
+
 ## [v4.2.0](https://github.com/azogue/aiopvpc/tree/v4.2.0) - Fix injection price sensor attributes (2023-05-29)
 
 [Full Changelog](https://github.com/azogue/aiopvpc/compare/v4.1.0...v4.2.0)

aiopvpc/prices.py

@@ -80,11 +80,11 @@ def _make_price_stats_attributes(
     except ZeroDivisionError:  # pragma: no cover
         pass
     attributes["max_price"] = max_price
-    best_price_at = next(iter(prices_sorted)).astimezone(timezone).hour
-    worst_price_at = next(iter(reversed(prices_sorted))).astimezone(timezone).hour
-    attributes["max_price_at"] = worst_price_at if sign_is_best else best_price_at
+    first_price_at = next(iter(prices_sorted)).astimezone(timezone).hour
+    last_price_at = next(iter(reversed(prices_sorted))).astimezone(timezone).hour
+    attributes["max_price_at"] = last_price_at if sign_is_best == 1 else first_price_at
     attributes["min_price"] = min_price
-    attributes["min_price_at"] = best_price_at if sign_is_best else worst_price_at
+    attributes["min_price_at"] = first_price_at if sign_is_best == 1 else last_price_at
     attributes["next_best_at"] = [
         ts.astimezone(timezone).hour for ts in prices_sorted.keys() if ts >= utc_time
     ]

pyproject.toml

@@ -40,7 +40,7 @@ markers = [
 
 [tool.poetry]
 name = "aiopvpc"
-version = "4.2.0"
+version = "4.2.1"
 description = "Retrieval of Spanish Electricity hourly prices (PVPC)"
 authors = ["Eugenio Panadero <[email protected]>"]
 license = "MIT"