Skip to content

Commit 89ae836

Browse files
authored
Add support for custom private image tags (#558)
1 parent f0808bf commit 89ae836

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.github/workflows/integ.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ jobs:
132132
run: cd tests && ./run-tests.sh ${{ matrix.arch-short }}-${{ matrix.auth_type }}
133133
env:
134134
POD_IDENTITY_ROLE_ARN: ${{ secrets.POD_IDENTITY_ROLE_ARN }}
135-
PRIVREPO: ghcr.io/${{ github.repository_owner }}/test-build:latest-${{ matrix.arch }}-${{ github.run_id }}
135+
PRIVREPO: ghcr.io/${{ github.repository_owner }}/test-build
136+
PRIVTAG: latest-${{ matrix.arch }}-${{ github.run_id }}
136137

137138
- name: Run cleanup
138139
if: always()

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
$(eval AWS_REGION=$(shell echo $${REGION:-us-east-1}))
2-
$(eval REGISTRY_NAME=$(shell echo $${PRIVREPO:-public.ecr.aws/aws-secrets-manager/secrets-store-csi-driver-provider-aws:latest}))
2+
$(eval REGISTRY_NAME=$(shell echo $${PRIVREPO:-public.ecr.aws/aws-secrets-manager/secrets-store-csi-driver-provider-aws}))
33
$(eval REPOBASE=$(shell echo $(REGISTRY_NAME) | cut -f1 -d/))
44

55
ifeq ($(REPOBASE), public.ecr.aws)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ cd secrets-store-csi-driver-provider-aws
286286
Next, set your region and repository name in bash shell variables to be used later:
287287
```bash
288288
export REGION=<REGION>
289-
export PRIVREPO=<ACCOUNT>.dkr.ecr.$REGION.amazonaws.com/secrets-store-csi-driver-provider-aws:latest
289+
export PRIVREPO=<ACCOUNT>.dkr.ecr.$REGION.amazonaws.com/secrets-store-csi-driver-provider-aws
290290
```
291291
Where **&lt;REGION&gt;** is the AWS region in which your Kubernetes cluster is running, and **&lt;ACCOUNT&gt;** is your AWS account Id. Next create your ECR repository if you have not already done so:
292292
```bash

deployment/private-installer.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ spec:
5858
hostNetwork: false
5959
containers:
6060
- name: provider-aws-installer
61-
image: ${PRIVREPO}
61+
image: ${PRIVREPO}${PRIVTAG:+:}${PRIVTAG}
6262
imagePullPolicy: Always
6363
args:
6464
- --provider-volume=/var/run/secrets-store-csi-providers

0 commit comments

Comments
 (0)