Skip to content

Commit 660f0d3

Browse files
authored
Fix: Accessibility Issues #2624 (#2642)
### Changes This PR has required code change to address the issue raised [here](#2624). Fixes #2624 ### References #2624 ### Testing I have tested the implementation using a [sample React app](https://github.com/auth0-samples/auth0-react-samples), following the steps provided to reproduce the issue. Please find the attached screen recording demonstrating the implementation details. * [x] This change adds unit test coverage * [ ] This change adds integration test coverage * [x] This change has been tested on the latest version of the platform/language ### Checklist * [x] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md) * [x] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md) * [x] All code quality tools/guidelines have been run/followed * [x] All relevant assets have been compiled
1 parent 75ae898 commit 660f0d3

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/__tests__/field/__snapshots__/social_buttons_pane.test.jsx.snap

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ exports[`SocialButtonsPane calls signUpError when isSignUp===true and terms were
3232
exports[`SocialButtonsPane renders correctly 1`] = `
3333
<div
3434
className="auth-lock-social-buttons-pane"
35+
tabIndex={0}
3536
>
3637
<div
3738
className="auth0-lock-social-buttons-container"
@@ -61,6 +62,7 @@ exports[`SocialButtonsPane renders correctly 1`] = `
6162
exports[`SocialButtonsPane shows header when instructions are available 1`] = `
6263
<div
6364
className="auth-lock-social-buttons-pane"
65+
tabIndex={0}
6466
>
6567
<p>
6668
instructions
@@ -93,6 +95,7 @@ exports[`SocialButtonsPane shows header when instructions are available 1`] = `
9395
exports[`SocialButtonsPane shows loading when showLoading === true 1`] = `
9496
<div
9597
className="auth-lock-social-buttons-pane"
98+
tabIndex={0}
9699
>
97100
<div
98101
className="auth0-lock-social-buttons-container"

src/field/social/social_buttons_pane.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export default class SocialButtonsPane extends React.Component {
5757
);
5858

5959
return (
60-
<div className="auth-lock-social-buttons-pane">
60+
<div className="auth-lock-social-buttons-pane" tabIndex={0}>
6161
{header}
6262
<div className="auth0-lock-social-buttons-container">{buttons}</div>
6363
{loading}

0 commit comments

Comments
 (0)