JsonLdMulti - Remove requirement for 2 items (#276)

J-Brk · web-flow · commit 134284922f6b · 2022-07-19T14:15:07.000-03:00
* Bug - JsonLdMulti - Remove requirement for 2 items Issue #275 * JsonLdMulti - Add unit test for single record output Implementing unit test for single record output
diff --git a/src/SEOTools/JsonLdMulti.php b/src/SEOTools/JsonLdMulti.php
@@ -47,11 +47,9 @@ public function __construct(array $defaultJsonLdData = [])
      */
     public function generate($minify = false)
     {
-        if (count($this->list) > 1) {
-            return array_reduce($this->list, function (string $output, JsonLd $jsonLd) {
-                return $output . (! $jsonLd->isEmpty() ? $jsonLd->generate() : '');
-            }, '');
-        }
+        return array_reduce($this->list, function (string $output, JsonLd $jsonLd) {
+            return $output . (! $jsonLd->isEmpty() ? $jsonLd->generate() : '');
+        }, '');
     }
 
     /**
diff --git a/tests/SEOTools/JsonLdMultiTest.php b/tests/SEOTools/JsonLdMultiTest.php
@@ -30,6 +30,15 @@ protected function setUp(): void
         $this->jsonLdMulti->newJsonLd();
     }
 
+    public function test_single_instance()
+    {
+        $jsonLdSingle = new JsonLdMulti();
+
+        $expected = '<html><head>' . $this->defaultJsonLdHtml . '</head></html>';
+
+        $this->assertEquals($this->makeDomDocument($expected)->C14N(), $this->makeDomDocument($jsonLdSingle->generate())->C14N());
+    }
+
     public function test_set_title()
     {
         $this->jsonLdMulti->setTitle('Kamehamehaaaaaaaa');

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,9 @@ public function __construct(array $defaultJsonLdData = [])`
`47`	`47`	`*/`
`48`	`48`	`public function generate($minify = false)`
`49`	`49`	`{`
`50`		`- if (count($this->list) > 1) {`
`51`		`- return array_reduce($this->list, function (string $output, JsonLd $jsonLd) {`
`52`		`- return $output . (! $jsonLd->isEmpty() ? $jsonLd->generate() : '');`
`53`		`- }, '');`
`54`		`- }`
	`50`	`+ return array_reduce($this->list, function (string $output, JsonLd $jsonLd) {`
	`51`	`+ return $output . (! $jsonLd->isEmpty() ? $jsonLd->generate() : '');`
	`52`	`+ }, '');`
`55`	`53`	`}`
`56`	`54`
`57`	`55`	`/**`