Skip to content

Add new account derivation APIs #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jun 30, 2025
Merged

Add new account derivation APIs #635

merged 39 commits into from
Jun 30, 2025

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Feb 10, 2025

Description

This adds a new account derivation APIs which allows wallets/users to use rotated and multikey accounts.

Test Plan

This was tested locally and has devnet e2e tests. This is because latest processors aren't in CLI

Related Links

Checklist

  • Have you ran pnpm fmt?
  • Have you updated the CHANGELOG.md?

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@heliuchuan heliuchuan marked this pull request as ready for review February 10, 2025 22:21
@heliuchuan heliuchuan requested a review from a team as a code owner February 10, 2025 22:21
@gregnazario gregnazario marked this pull request as draft February 11, 2025 17:11
@gregnazario
Copy link
Collaborator

Please ensure it builds / passes lints, and has a description, and then we can move it back out of draft.

fmt
@heliuchuan heliuchuan marked this pull request as ready for review May 16, 2025 10:19
@heliuchuan heliuchuan changed the title Add account discovery APIs Add new account derivation APIs May 16, 2025
Copy link
Contributor

@GhostWalker562 GhostWalker562 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, let's do a zeta version for this PR

* @returns A promise that resolves to a boolean indicating whether the account exists.
* @group Implementation
*/
async function doesAccountExistAtAddress(args: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregnazario Is this a good implementation for checking if an account exists at an address?

@heliuchuan
Copy link
Contributor Author

@aptos-labs/[email protected] published

@heliuchuan heliuchuan requested a review from GhostWalker562 May 16, 2025 19:08
fmt
fmt
@heliuchuan
Copy link
Contributor Author

@aptos-labs/[email protected] published

@heliuchuan heliuchuan merged commit d106336 into main Jun 30, 2025
10 checks passed
@heliuchuan heliuchuan deleted the discovery branch June 30, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants