-
Notifications
You must be signed in to change notification settings - Fork 72
Add new account derivation APIs #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please ensure it builds / passes lints, and has a description, and then we can move it back out of draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, let's do a zeta
version for this PR
* @returns A promise that resolves to a boolean indicating whether the account exists. | ||
* @group Implementation | ||
*/ | ||
async function doesAccountExistAtAddress(args: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregnazario Is this a good implementation for checking if an account exists at an address?
@aptos-labs/[email protected] published |
@aptos-labs/[email protected] published |
Description
This adds a new account derivation APIs which allows wallets/users to use rotated and multikey accounts.
Test Plan
This was tested locally and has devnet e2e tests. This is because latest processors aren't in CLI
Related Links
Checklist
pnpm fmt
?CHANGELOG.md
?