[deps] Deprecate < node 20, upgrade CI deps (#610)

gregnazario · web-flow · commit f956fddbfd13 · 2025-01-09T22:08:18.000Z
* [github] Upgrade v3 to v4 as v3 is deprecated for old actions

* [deps] Update pnpm, node versions to newest minor version

* [deps] Override cross spawn

Overriding cross-spawn to &gt;= 7.0.5 as per pnpm audit

* [deps] Only specify PNPM engine in one place
diff --git a/.github/actions/run-build/action.yaml b/.github/actions/run-build/action.yaml
@@ -6,13 +6,11 @@ runs:
   using: composite
   steps:
     # Install node and pnpm.
-    - uses: actions/setup-node@v3
+    - uses: actions/setup-node@v4
       with:
         node-version-file: .node-version
         registry-url: "https://registry.npmjs.org"
     - uses: pnpm/action-setup@v4
-      with:
-        version: 8.9.0
 
     # Run package install and build
     - run: pnpm install --frozen-lockfile && pnpm build
diff --git a/.github/actions/run-check-version/action.yaml b/.github/actions/run-check-version/action.yaml
@@ -6,13 +6,11 @@ runs:
   using: composite
   steps:
     # Install node and pnpm.
-    - uses: actions/setup-node@v3
+    - uses: actions/setup-node@v4
       with:
         node-version-file: .node-version
         registry-url: "https://registry.npmjs.org"
     - uses: pnpm/action-setup@v4
-      with:
-        version: 8.9.0
 
     # Run version check
     - run: pnpm check-version
diff --git a/.github/actions/run-examples/action.yaml b/.github/actions/run-examples/action.yaml
@@ -6,13 +6,11 @@ runs:
   using: composite
   steps:
     # Install node and pnpm.
-    - uses: actions/setup-node@v3
+    - uses: actions/setup-node@v4
       with:
         node-version-file: .node-version
         registry-url: "https://registry.npmjs.org"
     - uses: pnpm/action-setup@v4
-      with:
-        version: 8.9.0
 
     # Run package install. If install fails, it probably means the updated lockfile was
     # not included in the commit.
diff --git a/.github/actions/run-fmt/action.yaml b/.github/actions/run-fmt/action.yaml
@@ -6,13 +6,11 @@ runs:
   using: composite
   steps:
     # Install node and pnpm.
-    - uses: actions/setup-node@v3
+    - uses: actions/setup-node@v4
       with:
         node-version-file: .node-version
         registry-url: "https://registry.npmjs.org"
     - uses: pnpm/action-setup@v4
-      with:
-        version: 8.9.0
 
     # Verify that the format is correct
     - run: pnpm install --frozen-lockfile && pnpm _fmt --check
diff --git a/.github/actions/run-lint/action.yaml b/.github/actions/run-lint/action.yaml
@@ -6,13 +6,11 @@ runs:
   using: composite
   steps:
     # Install node and pnpm.
-    - uses: actions/setup-node@v3
+    - uses: actions/setup-node@v4
       with:
         node-version-file: .node-version
         registry-url: "https://registry.npmjs.org"
     - uses: pnpm/action-setup@v4
-      with:
-        version: 8.9.0
 
     # Run eslint
     - run: pnpm install --frozen-lockfile && pnpm lint
diff --git a/.github/actions/run-tests/action.yaml b/.github/actions/run-tests/action.yaml
@@ -9,13 +9,11 @@ runs:
   using: composite
   steps:
     # Install node and pnpm.
-    - uses: actions/setup-node@v3
+    - uses: actions/setup-node@v4
       with:
         node-version-file: .node-version
         registry-url: "https://registry.npmjs.org"
     - uses: pnpm/action-setup@v4
-      with:
-        version: 8.9.0
 
     # Run package install. If install fails, it probably means the updated lockfile was
     # not included in the commit.
diff --git a/.github/workflows/run-build.yaml b/.github/workflows/run-build.yaml
@@ -13,7 +13,7 @@ jobs:
   run-tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ env.GIT_SHA }}
       - uses: ./.github/actions/run-build
diff --git a/.github/workflows/run-check-version.yaml b/.github/workflows/run-check-version.yaml
@@ -14,7 +14,7 @@ jobs:
   run-tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ env.GIT_SHA }}
       - uses: ./.github/actions/run-check-version
diff --git a/.github/workflows/run-examples.yaml b/.github/workflows/run-examples.yaml
@@ -13,7 +13,7 @@ jobs:
   run-tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ env.GIT_SHA }}
       - uses: ./.github/actions/run-examples
diff --git a/.github/workflows/run-fmt.yaml b/.github/workflows/run-fmt.yaml
@@ -13,7 +13,7 @@ jobs:
   run-tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ env.GIT_SHA }}
       - uses: ./.github/actions/run-fmt
diff --git a/.github/workflows/run-lint.yaml b/.github/workflows/run-lint.yaml
@@ -13,7 +13,7 @@ jobs:
   run-tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ env.GIT_SHA }}
       - uses: ./.github/actions/run-lint
diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml
@@ -13,7 +13,7 @@ jobs:
   run-tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ env.GIT_SHA }}
       - uses: ./.github/actions/run-tests
diff --git a/.node-version b/.node-version
@@ -1 +1 @@
-v22.11.0
+v22.12.0
diff --git a/.tool-versions b/.tool-versions
@@ -0,0 +1,2 @@
+pnpm 8.15.1
+nodejs 22.12.0
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ All notable changes to the Aptos TypeScript SDK will be captured in this file. T
 
 # Unreleased
 
+- node now no longer supports older than v20
+- overriding cross spawn for patch
 - Add `AccountUtils` class to help with account serialization and deserialization
 - Add `SingleKeySigner` interface which adds the ability to get the `AnyPublicKey` from a `SingleKeyAccount`
 - We now throw an error earlier when you try to use the faucet with testnet or mainnet, rather than letting the call happen and then fail later.
diff --git a/package.json b/package.json
@@ -1,10 +1,10 @@
 {
   "name": "@aptos-labs/ts-sdk",
   "description": "Aptos TypeScript SDK",
-  "packageManager": "pnpm@8.9.0",
+  "packageManager": "pnpm@8.15.1",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=11.0.0"
+    "node": ">=20.0.0"
   },
   "bugs": {
     "url": "https://github.com/aptos-labs/aptos-ts-sdk/issues/new/choose"
@@ -96,5 +96,10 @@
     "typedoc-plugin-missing-exports": "^3.0.0",
     "typescript": "^5.6.2"
   },
+  "pnpm": {
+    "overrides": {
+      "cross-spawn": ">=7.0.5"
+    }
+  },
   "version": "1.33.1"
-}
+}
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
