Saved Queries save modal closes if no changes were made on that tab

[msyavuz]

Bug description

1. Go to saved queries
2. Click add query
3. Add a new tab and click save
4. Save modal disappears if no changes were made to the query

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

• I have searched Superset docs and Slack and didn't find a solution to my problem.
• I have searched the GitHub issue tracker and didn't find a similar bug report.
• I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[dosubot]

The behavior you're experiencing, where the save modal closes if no changes are made to a query in a new tab, might be related to how the SaveQuery component handles the save action. The modal is designed to close when the onSaveWrapper function is called, which includes logging the save action and then closing the modal. However, if no changes are detected, the modal might be closing prematurely due to the logic that determines whether a save action is necessary ^[1].

Unfortunately, I couldn't find specific details in the repository about how changes are detected in a new tab or if there's a condition that prevents the modal from closing when no changes are made. It might be worth investigating the logic in the SaveQuery component further to see if there's a condition or flag that could be adjusted to prevent the modal from closing in this scenario.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other}

[alexandrusoare]

Hey I would like to solve this issue

[alexandrusoare]

I was able to replicate this issue before the Modal Upgrade was introduced so I think this will require a separate investigation

[rusackas]

Weird. This issue has been quiet for a while, but it's still very much there.