chore: update chart list e2e and component tests (#34393)

Co-authored-by: Claude <[email protected]>

Author: sadpandajoe

superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts

@@ -94,67 +94,12 @@ describe('Charts list', () => {
     });
   });
 
-  describe('list mode', () => {
-    before(() => {
-      visitChartList();
-      setGridMode('list');
-    });
-
-    it('should load rows in list mode', () => {
-      cy.getBySel('listview-table').should('be.visible');
-      cy.getBySel('sort-header').eq(1).contains('Name');
-      cy.getBySel('sort-header').eq(2).contains('Type');
-      cy.getBySel('sort-header').eq(3).contains('Dataset');
-      cy.getBySel('sort-header').eq(4).contains('On dashboards');
-      cy.getBySel('sort-header').eq(5).contains('Owners');
-      cy.getBySel('sort-header').eq(6).contains('Last modified');
-      cy.getBySel('sort-header').eq(7).contains('Actions');
-    });
-
-    it('should bulk select in list mode', () => {
-      toggleBulkSelect();
-      cy.get('[aria-label="Select all"]').click();
-      cy.get('input[type="checkbox"]:checked').should('have.length', 26);
-      cy.getBySel('bulk-select-copy').contains('25 Selected');
-      cy.getBySel('bulk-select-action')
-        .should('have.length', 2)
-        .then($btns => {
-          expect($btns).to.contain('Delete');
-          expect($btns).to.contain('Export');
-        });
-      cy.getBySel('bulk-select-deselect-all').click();
-      cy.get('input[type="checkbox"]:checked').should('have.length', 0);
-      cy.getBySel('bulk-select-copy').contains('0 Selected');
-      cy.getBySel('bulk-select-action').should('not.exist');
-    });
-  });
-
   describe('card mode', () => {
     before(() => {
       visitChartList();
       setGridMode('card');
     });
 
-    it('should load rows in card mode', () => {
-      cy.getBySel('listview-table').should('not.exist');
-      cy.getBySel('styled-card').should('have.length', 25);
-    });
-
-    it('should bulk select in card mode', () => {
-      toggleBulkSelect();
-      cy.getBySel('styled-card').click({ multiple: true });
-      cy.getBySel('bulk-select-copy').contains('25 Selected');
-      cy.getBySel('bulk-select-action')
-        .should('have.length', 2)
-        .then($btns => {
-          expect($btns).to.contain('Delete');
-          expect($btns).to.contain('Export');
-        });
-      cy.getBySel('bulk-select-deselect-all').click();
-      cy.getBySel('bulk-select-copy').contains('0 Selected');
-      cy.getBySel('bulk-select-action').should('not.exist');
-    });
-
     it('should preserve other filters when sorting', () => {
       cy.getBySel('styled-card').should('have.length', 25);
       setFilter('Type', 'Big Number');

superset-frontend/src/components/FacePile/FacePile.test.tsx

@@ -16,11 +16,29 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { act, fireEvent, render, screen } from 'spec/helpers/testing-library';
+import {
+  act,
+  fireEvent,
+  render,
+  screen,
+  within,
+  cleanup,
+} from 'spec/helpers/testing-library';
 import { store } from 'src/views/store';
+import { isFeatureEnabled } from '@superset-ui/core';
 import { FacePile } from '.';
 import { getRandomColor } from './utils';
 
+// Mock the feature flag
+jest.mock('@superset-ui/core', () => ({
+  ...jest.requireActual('@superset-ui/core'),
+  isFeatureEnabled: jest.fn(),
+}));
+
+const mockIsFeatureEnabled = isFeatureEnabled as jest.MockedFunction<
+  typeof isFeatureEnabled
+>;
+
 const users = [...new Array(10)].map((_, i) => ({
   first_name: 'user',
   last_name: `${i}`,
@@ -29,37 +47,99 @@ const users = [...new Array(10)].map((_, i) => ({
 
 beforeEach(() => {
   jest.useFakeTimers();
+  // Default to Slack avatars disabled
+  mockIsFeatureEnabled.mockImplementation(() => false);
 });
 
 afterEach(() => {
   jest.useRealTimers();
+  mockIsFeatureEnabled.mockReset();
+  cleanup();
 });
 
 describe('FacePile', () => {
-  let container: HTMLElement;
+  it('renders empty state with no users', () => {
+    const { container } = render(<FacePile users={[]} />, { store });
+
+    expect(container.querySelector('.ant-avatar-group')).toBeInTheDocument();
+    expect(container.querySelectorAll('.ant-avatar')).toHaveLength(0);
+  });
+
+  it('renders single user without truncation', () => {
+    const { container } = render(<FacePile users={users.slice(0, 1)} />, {
+      store,
+    });
+
+    const avatars = container.querySelectorAll('.ant-avatar');
+    expect(avatars).toHaveLength(1);
+    expect(within(container).getByText('U0')).toBeInTheDocument();
+    expect(within(container).queryByText(/\+/)).not.toBeInTheDocument();
+  });
+
+  it('renders multiple users no truncation', () => {
+    const { container } = render(<FacePile users={users.slice(0, 4)} />, {
+      store,
+    });
 
-  beforeEach(() => {
-    ({ container } = render(<FacePile users={users} />, { store }));
+    const avatars = container.querySelectorAll('.ant-avatar');
+    expect(avatars).toHaveLength(4);
+    expect(within(container).getByText('U0')).toBeInTheDocument();
+    expect(within(container).getByText('U1')).toBeInTheDocument();
+    expect(within(container).getByText('U2')).toBeInTheDocument();
+    expect(within(container).getByText('U3')).toBeInTheDocument();
+    expect(within(container).queryByText(/\+/)).not.toBeInTheDocument();
   });
 
-  it('is a valid element', () => {
-    const exposedFaces = screen.getAllByText(/U/);
-    expect(exposedFaces).toHaveLength(4);
-    const overflownFaces = screen.getByText('+6');
-    expect(overflownFaces).toBeVisible();
+  it('renders multiple users with truncation', () => {
+    const { container } = render(<FacePile users={users} />, { store });
 
-    // Display user info when hovering over one of exposed face in the pile.
-    fireEvent.mouseEnter(exposedFaces[0]);
+    // Should show 4 avatars + 1 overflow indicator = 5 total elements
+    const avatars = container.querySelectorAll('.ant-avatar');
+    expect(avatars).toHaveLength(5);
+
+    // Should show first 4 users
+    expect(within(container).getByText('U0')).toBeInTheDocument();
+    expect(within(container).getByText('U1')).toBeInTheDocument();
+    expect(within(container).getByText('U2')).toBeInTheDocument();
+    expect(within(container).getByText('U3')).toBeInTheDocument();
+
+    // Should show overflow count (+6 because 10 total - 4 shown)
+    expect(within(container).getByText('+6')).toBeInTheDocument();
+  });
+
+  it('displays user tooltip on hover', () => {
+    const { container } = render(<FacePile users={users.slice(0, 2)} />, {
+      store,
+    });
+
+    const firstAvatar = within(container).getByText('U0');
+    fireEvent.mouseEnter(firstAvatar);
     act(() => jest.runAllTimers());
+
     expect(screen.getByRole('tooltip')).toHaveTextContent('user 0');
   });
 
-  it('renders an Avatar', () => {
-    expect(container.querySelector('.ant-avatar')).toBeVisible();
-  });
+  it('displays avatar images when Slack avatars are enabled', () => {
+    // Enable Slack avatars feature flag
+    mockIsFeatureEnabled.mockImplementation(
+      feature => feature === 'SLACK_ENABLE_AVATARS',
+    );
+
+    const { container: testContainer } = render(
+      <FacePile users={users.slice(0, 2)} />,
+      {
+        store,
+      },
+    );
+
+    const avatars = testContainer.querySelectorAll('.ant-avatar');
+    expect(avatars).toHaveLength(2);
 
-  it('hides overflow', () => {
-    expect(container.querySelectorAll('.ant-avatar')).toHaveLength(5);
+    // Should have img elements with correct src attributes
+    const imgs = testContainer.querySelectorAll('.ant-avatar img');
+    expect(imgs).toHaveLength(2);
+    expect(imgs[0]).toHaveAttribute('src', '/api/v1/user/0/avatar.png');
+    expect(imgs[1]).toHaveAttribute('src', '/api/v1/user/1/avatar.png');
   });
 });
 

superset-frontend/src/components/Tag/utils.test.tsx

@@ -16,7 +16,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { tagToSelectOption } from 'src/components/Tag/utils';
+import fetchMock from 'fetch-mock';
+import rison from 'rison';
+import { tagToSelectOption, loadTags } from 'src/components/Tag/utils';
 
 describe('tagToSelectOption', () => {
   test('converts a Tag object with table_name to a SelectTagsValue', () => {
@@ -35,3 +37,166 @@ describe('tagToSelectOption', () => {
     expect(tagToSelectOption(tag)).toEqual(expectedSelectTagsValue);
   });
 });
+
+describe('loadTags', () => {
+  beforeEach(() => {
+    fetchMock.reset();
+  });
+
+  afterEach(() => {
+    fetchMock.restore();
+  });
+
+  test('constructs correct API query with custom tag filter', async () => {
+    const mockTags = [
+      { id: 1, name: 'analytics', type: 1 },
+      { id: 2, name: 'finance', type: 1 },
+    ];
+
+    fetchMock.get('glob:*/api/v1/tag/*', {
+      result: mockTags,
+      count: 2,
+    });
+
+    await loadTags('analytics', 0, 25);
+
+    // Verify the API was called with correct parameters
+    const calls = fetchMock.calls();
+    expect(calls).toHaveLength(1);
+
+    const [url] = calls[0];
+    expect(url).toContain('/api/v1/tag/?q=');
+
+    // Extract and decode the query parameter
+    const urlObj = new URL(url);
+    const queryParam = urlObj.searchParams.get('q');
+    expect(queryParam).not.toBeNull();
+    const decodedQuery = rison.decode(queryParam!) as Record<string, any>;
+
+    // Verify the query structure
+    expect(decodedQuery).toEqual({
+      filters: [
+        { col: 'name', opr: 'ct', value: 'analytics' },
+        { col: 'type', opr: 'custom_tag', value: true },
+      ],
+      page: 0,
+      page_size: 25,
+      order_column: 'name',
+      order_direction: 'asc',
+    });
+  });
+
+  test('returns correctly transformed data', async () => {
+    const mockTags = [
+      { id: 1, name: 'analytics', type: 1 },
+      { id: 2, name: 'finance', type: 1 },
+    ];
+
+    fetchMock.get('glob:*/api/v1/tag/*', {
+      result: mockTags,
+      count: 2,
+    });
+
+    const result = await loadTags('', 0, 25);
+
+    expect(result).toEqual({
+      data: [
+        { value: 1, label: 'analytics', key: 1 },
+        { value: 2, label: 'finance', key: 2 },
+      ],
+      totalCount: 2,
+    });
+  });
+
+  test('handles search parameter correctly', async () => {
+    fetchMock.get('glob:*/api/v1/tag/*', {
+      result: [],
+      count: 0,
+    });
+
+    await loadTags('financial-data', 0, 25);
+
+    const calls = fetchMock.calls();
+    const [url] = calls[0];
+    const urlObj = new URL(url);
+    const queryParam = urlObj.searchParams.get('q');
+    expect(queryParam).not.toBeNull();
+    const decodedQuery = rison.decode(queryParam!) as Record<string, any>;
+
+    // Should include the search term in the name filter
+    expect(decodedQuery.filters[0]).toEqual({
+      col: 'name',
+      opr: 'ct',
+      value: 'financial-data',
+    });
+  });
+
+  test('handles pagination parameters correctly', async () => {
+    fetchMock.get('glob:*/api/v1/tag/*', {
+      result: [],
+      count: 0,
+    });
+
+    await loadTags('', 2, 10);
+
+    const calls = fetchMock.calls();
+    const [url] = calls[0];
+    const urlObj = new URL(url);
+    const queryParam = urlObj.searchParams.get('q');
+    expect(queryParam).not.toBeNull();
+    const decodedQuery = rison.decode(queryParam!) as Record<string, any>;
+
+    expect(decodedQuery.page).toBe(2);
+    expect(decodedQuery.page_size).toBe(10);
+  });
+
+  test('always includes custom tag filter regardless of other parameters', async () => {
+    fetchMock.get('glob:*/api/v1/tag/*', {
+      result: [],
+      count: 0,
+    });
+
+    // Test with different combinations of parameters
+    await loadTags('', 0, 25);
+    await loadTags('search-term', 1, 50);
+    await loadTags('another-search', 5, 100);
+
+    const calls = fetchMock.calls();
+
+    // Verify all calls include the custom tag filter
+    calls.forEach(call => {
+      const [url] = call;
+      const urlObj = new URL(url);
+      const queryParam = urlObj.searchParams.get('q');
+      expect(queryParam).not.toBeNull();
+      const decodedQuery = rison.decode(queryParam!) as Record<string, any>;
+
+      // Every call should have the custom tag filter
+      expect(decodedQuery.filters).toContainEqual({
+        col: 'type',
+        opr: 'custom_tag',
+        value: true,
+      });
+    });
+  });
+
+  test('maintains correct order specification', async () => {
+    fetchMock.get('glob:*/api/v1/tag/*', {
+      result: [],
+      count: 0,
+    });
+
+    await loadTags('test', 0, 25);
+
+    const calls = fetchMock.calls();
+    const [url] = calls[0];
+    const urlObj = new URL(url);
+    const queryParam = urlObj.searchParams.get('q');
+    expect(queryParam).not.toBeNull();
+    const decodedQuery = rison.decode(queryParam!) as Record<string, any>;
+
+    // Should always order by name ascending
+    expect(decodedQuery.order_column).toBe('name');
+    expect(decodedQuery.order_direction).toBe('asc');
+  });
+});