build(deps): remove legacy browser polyfills (#33853)

Signed-off-by: hainenber <[email protected]>

Author: hainenber

superset-frontend/jest.config.js

@@ -32,7 +32,7 @@ module.exports = {
       '<rootDir>/node_modules/@superset-ui/$1/src/$2',
     '^@superset-ui/([^/]+)$': '<rootDir>/node_modules/@superset-ui/$1/src',
   },
-  testEnvironment: 'jsdom',
+  testEnvironment: '<rootDir>/spec/helpers/jsDomWithFetchAPI.ts',
   modulePathIgnorePatterns: ['<rootDir>/packages/generator-superset'],
   setupFilesAfterEnv: ['<rootDir>/spec/helpers/setup.ts'],
   snapshotSerializers: ['@emotion/jest/serializer'],

superset-frontend/package-lock.json

@@ -120,7 +120,6 @@
     "@visx/scale": "^3.5.0",
     "@visx/tooltip": "^3.0.0",
     "@visx/xychart": "^3.5.1",
-    "abortcontroller-polyfill": "^1.7.8",
     "ag-grid-community": "33.1.1",
     "ag-grid-react": "33.1.1",
     "antd": "^5.24.6",

superset-frontend/package.json

@@ -62,7 +62,6 @@
     "rison": "^0.1.1",
     "seedrandom": "^3.0.5",
     "@visx/responsive": "^3.12.0",
-    "whatwg-fetch": "^3.6.20",
     "xss": "^1.0.14"
   },
   "devDependencies": {

superset-frontend/packages/superset-ui-core/package.json

@@ -93,7 +93,6 @@ Per-request aborting is implemented through the `AbortController` API:
 
 ```javascript
 import { SupersetClient } from '@superset-ui/core';
-import AbortController from 'abortcontroller-polyfill';
 
 const controller = new AbortController();
 const { signal } = controller;

superset-frontend/packages/superset-ui-core/src/connection/README.md

@@ -17,7 +17,6 @@
  * under the License.
  */
 
-import 'whatwg-fetch';
 import fetchRetry from 'fetch-retry';
 import { CallApi, Payload, JsonValue, JsonObject } from '../types';
 import {

superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts

@@ -16,7 +16,6 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import 'whatwg-fetch'; // for adding Response polyfill
 import {
   JsonObject,
   SupersetApiError,

superset-frontend/packages/superset-ui-core/test/query/api/v1/handleError.test.ts

@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import JSDOMEnvironment from 'jest-environment-jsdom';
+
+// https://github.com/facebook/jest/blob/v29.4.3/website/versioned_docs/version-29.4/Configuration.md#testenvironment-string
+export default class FixJSDOMEnvironment extends JSDOMEnvironment {
+  constructor(...args: ConstructorParameters<typeof JSDOMEnvironment>) {
+    super(...args);
+
+    // FIXME https://github.com/jsdom/jsdom/issues/1724
+    this.global.fetch = fetch;
+    this.global.Headers = Headers;
+    this.global.Request = Request;
+    this.global.Response = Response;
+    this.global.AbortSignal = AbortSignal;
+    this.global.AbortController = AbortController;
+  }
+}

superset-frontend/spec/helpers/jsDomWithFetchAPI.ts

@@ -19,7 +19,6 @@
 import { AriaAttributes } from 'react';
 import 'core-js/stable';
 import 'regenerator-runtime/runtime';
-import 'abortcontroller-polyfill/dist/abortcontroller-polyfill-only';
 import jQuery from 'jquery';
 // https://jestjs.io/docs/jest-object#jestmockmodulename-factory-options
 // in order to mock modules in test case, so avoid absolute import module

superset-frontend/spec/helpers/shim.tsx

@@ -17,7 +17,6 @@
  * under the License.
  */
 import { setConfig as setHotLoaderConfig } from 'react-hot-loader';
-import 'abortcontroller-polyfill/dist/abortcontroller-polyfill-only';
 import dayjs from 'dayjs';
 // eslint-disable-next-line no-restricted-imports
 import { configure, makeApi, initFeatureFlags } from '@superset-ui/core';

superset-frontend/src/preamble.ts

@@ -258,7 +258,6 @@ const config = {
           name: 'vendors',
           test: new RegExp(
             `/node_modules/(${[
-              'abortcontroller-polyfill',
               'react',
               'react-dom',
               'prop-types',