chore: use logger on all migrations (#34521)

Author: villebro

superset/migrations/shared/catalogs.py

@@ -37,7 +37,7 @@
 )
 from superset.models.core import Database
 
-logger = logging.getLogger("alembic")
+logger = logging.getLogger("alembic.env")
 
 Base: Type[Any] = declarative_base()
 

superset/migrations/shared/migrate_viz/base.py

@@ -28,7 +28,7 @@
 from superset.utils import json
 from superset.utils.date_parser import get_since_until
 
-logger = logging.getLogger("alembic")
+logger = logging.getLogger("alembic.env")
 
 Base = declarative_base()
 

superset/migrations/shared/security_converge.py

@@ -29,7 +29,7 @@
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy.orm import Load, relationship, Session
 
-logger = logging.getLogger(__name__)
+logger = logging.getLogger("alembic.env")
 
 Base = declarative_base()
 

superset/migrations/shared/utils.py

@@ -49,7 +49,7 @@
 RED = "\033[31m"
 LRED = "\033[91m"
 
-logger = logging.getLogger("alembic")
+logger = logging.getLogger("alembic.env")
 
 DEFAULT_BATCH_SIZE = int(os.environ.get("BATCH_SIZE", 1000))
 

superset/migrations/versions/2016-05-27_15-03_1226819ee0e3_fix_wrong_constraint_on_table_columns.py

@@ -33,6 +33,8 @@
 revision = "1226819ee0e3"
 down_revision = "956a063c52b3"
 
+logger = logging.getLogger("alembic.env")
+
 
 naming_convention = {
     "fk": "fk_%(table_name)s_%(column_0_name)s_%(referred_table_name)s"
@@ -61,7 +63,7 @@ def upgrade():
                 ["datasource_name"],
             )
     except:  # noqa: E722
-        logging.warning("Could not find or drop constraint on `columns`")
+        logger.warning("Could not find or drop constraint on `columns`")
 
 
 def downgrade():

superset/migrations/versions/2016-09-22_10-21_3b626e2a6783_sync_db_with_models.py

@@ -38,6 +38,8 @@
 revision = "3b626e2a6783"
 down_revision = "eca4694defa7"
 
+logger = logging.getLogger("alembic.env")
+
 
 def upgrade():
     # cleanup after: https://github.com/airbnb/superset/pull/1078
@@ -60,7 +62,7 @@ def upgrade():
             batch_op.drop_column("druid_datasource_id")
             batch_op.drop_column("table_id")
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))
 
     # fixed issue: https://github.com/airbnb/superset/issues/466
     try:
@@ -69,26 +71,26 @@ def upgrade():
                 None, "datasources", ["datasource_name"], ["datasource_name"]
             )
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))
     try:
         with op.batch_alter_table("query") as batch_op:
             batch_op.create_unique_constraint("client_id", ["client_id"])
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))
 
     try:
         with op.batch_alter_table("query") as batch_op:
             batch_op.drop_column("name")
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))
 
 
 def downgrade():
     try:
         with op.batch_alter_table("tables") as batch_op:
             batch_op.create_index("table_name", ["table_name"], unique=True)
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))
 
     try:
         with op.batch_alter_table("slices") as batch_op:
@@ -113,7 +115,7 @@ def downgrade():
             )
             batch_op.create_foreign_key("slices_ibfk_2", "tables", ["table_id"], ["id"])
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))
 
     try:
         fk_columns = generic_find_constraint_name(
@@ -125,11 +127,11 @@ def downgrade():
         with op.batch_alter_table("columns") as batch_op:
             batch_op.drop_constraint(fk_columns, type_="foreignkey")
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))
 
     op.add_column("query", sa.Column("name", sa.String(length=256), nullable=True))
     try:
         with op.batch_alter_table("query") as batch_op:
             batch_op.drop_constraint("client_id", type_="unique")
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))

superset/migrations/versions/2016-10-05_11-30_b46fa1b0b39e_add_params_to_tables.py

@@ -31,6 +31,8 @@
 import sqlalchemy as sa  # noqa: E402
 from alembic import op  # noqa: E402
 
+logger = logging.getLogger("alembic.env")
+
 
 def upgrade():
     op.add_column("tables", sa.Column("params", sa.Text(), nullable=True))
@@ -40,4 +42,4 @@ def downgrade():
     try:
         op.drop_column("tables", "params")
     except Exception as ex:
-        logging.warning(str(ex))
+        logger.warning(str(ex))

superset/migrations/versions/2017-03-16_18-10_db527d8c4c78_add_db_verbose_name.py

@@ -31,6 +31,8 @@
 import sqlalchemy as sa  # noqa: E402
 from alembic import op  # noqa: E402
 
+logger = logging.getLogger("alembic.env")
+
 
 def upgrade():
     op.add_column(
@@ -44,12 +46,12 @@ def upgrade():
         op.create_unique_constraint(None, "dbs", ["verbose_name"])
         op.create_unique_constraint(None, "clusters", ["verbose_name"])
     except Exception:
-        logging.info("Constraint not created, expected when using sqlite")
+        logger.info("Constraint not created, expected when using sqlite")
 
 
 def downgrade():
     try:
         op.drop_column("dbs", "verbose_name")
         op.drop_column("clusters", "verbose_name")
     except Exception as ex:
-        logging.exception(ex)
+        logger.exception(ex)

superset/migrations/versions/2017-10-03_14-37_4736ec66ce19_.py

@@ -37,6 +37,8 @@
 revision = "4736ec66ce19"
 down_revision = "f959a6652acd"
 
+logger = logging.getLogger("alembic.env")
+
 conv = {
     "fk": "fk_%(table_name)s_%(column_0_name)s_%(referred_table_name)s",
     "uq": "uq_%(table_name)s_%(column_0_name)s",
@@ -119,13 +121,13 @@ def upgrade():
                 type_="unique",
             )
     except Exception as ex:
-        logging.warning(
+        logger.warning(
             "Constraint drop failed, you may want to do this "
             "manually on your database. For context, this is a known "
             "issue around nondeterministic constraint names on Postgres "
             "and perhaps more databases through SQLAlchemy."
         )
-        logging.exception(ex)
+        logger.exception(ex)
 
 
 def downgrade():

superset/migrations/versions/2018-05-09_23-45_e502db2af7be_add_template_params_to_tables.py

@@ -22,12 +22,16 @@
 
 """
 
+import logging
+
+import sqlalchemy as sa  # noqa: E402
+from alembic import op  # noqa: E402
+
 # revision identifiers, used by Alembic.
 revision = "e502db2af7be"
 down_revision = "5ccf602336a0"
 
-import sqlalchemy as sa  # noqa: E402
-from alembic import op  # noqa: E402
+logger = logging.getLogger("alembic.env")
 
 
 def upgrade():
@@ -38,4 +42,4 @@ def downgrade():
     try:
         op.drop_column("tables", "template_params")
     except Exception as ex:
-        logging.warning(str(ex))  # noqa: F821
+        logger.warning(str(ex))