-
Notifications
You must be signed in to change notification settings - Fork 2k
[Bug] [seatunnel-connectors] [seatunnel-connector-spark-clickhouse] Data cannot be imported to all nodes by configuring split_mode and sharding_key #4772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wuxizhi777
wants to merge
15
commits into
apache:dev
Choose a base branch
from
wuxizhi777:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b739cc9
Add parentheses(), because '%' is higher than '&'
55e194e
Merge branch 'dev' of https://github.com/wuxizhi777/incubator-seatunn…
2fe1091
Add parentheses(), because '%' is higher than '&'
wuxizhi777 175358f
Adjustment format
wuxizhi777 c84d43e
Merge branch 'apache:dev' into dev
wuxizhi777 7d23695
Merge branch 'apache:dev' into dev
wuxizhi777 352909c
Merge branch 'apache:dev' into dev
wuxizhi777 5709e82
test unit for https://github.com/apache/seatunnel/pull/4772
wuxizhi777 4845fe3
Merge branch 'apache:dev' into dev
wuxizhi777 a0d36bb
add UT for getShard
wuxizhi777 fb0a852
add UT for getShard
wuxizhi777 e720046
Merge branch 'apache:dev' into dev
wuxizhi777 3cedd70
Merge branch 'apache:dev' into dev
wuxizhi777 5c08b57
Merge branch 'apache:dev' into dev
wuxizhi777 b403ab4
Merge branch 'apache:dev' into dev
wuxizhi777 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case look weird, it only prove the logic of
(hashValue & Long.MAX_VALUE) % modulo
are right. But can not make sure thegetShard
method return right result. I think the test case should testgetShard
method.