-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
improvementPR that improves existing functionalityPR that improves existing functionality
Description
Feature Request / Improvement
Re-opening the following issue: #6739
Query engine
Other
Willingness to contribute
- I can contribute this improvement/feature independentlyI would be willing to contribute this improvement/feature with guidance from the Iceberg communityI cannot contribute this improvement/feature at this timeTo pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
JeonDaehong
Metadata
Metadata
Assignees
Labels
improvementPR that improves existing functionalityPR that improves existing functionality
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
JeonDaehong commentedon Jun 2, 2025
Hello !
Thanks for the suggestion regarding the performance improvements — it sounds like a very interesting enhancement!
If possible, I’d be happy to take a look and try implementing this.
Before getting started, could you please clarify what specific changes would be needed in Iceberg to support the CRT-based S3 client?
For example:
FileIO
orS3FileIO
is configured?It would be great to understand the scope of changes more clearly before moving forward.
guizmaii commentedon Jun 2, 2025
Hi @JeonDaehong,
Thanks for showing interest in this improvement
I'm not familiar with the specifics of what needs to change. I don't know the internals of Iceberg, nor I'm an expert of Iceberg
What I've seen is that if I globally exclude the following dependency from my project:
software.amazon.awssdk::apache-client
, then the following code fails to execute:iceberg/aws/src/main/java/org/apache/iceberg/aws/HttpClientProperties.java
Lines 235 to 241 in 2cdff36
AFAICT, it seems like Iceberg only supports the
UrlConnectionHttpClient
andApacheHttpClient
implementations of the AWS SDK HTTP client. It'd probably be interesting in supporting Netty and AWS CRTHope it helps 🙂
JeonDaehong commentedon Jun 2, 2025
@guizmaii
Thank you for the valuable insight!
Based on my brief investigation so far, it appears that, as you mentioned, Iceberg currently supports only ApacheHttpClient and UrlConnectionHttpClient through the HttpClientProperties class. Other AWS SDK HTTP client implementations like Netty or CrtHttpClient do not seem to be supported at this time.
I'll look into whether there's potential for Iceberg to be enhanced to allow more flexible configuration of SdkHttpClient.
JeonDaehong commentedon Jun 2, 2025
If there's any contributor who is more familiar with this issue, I’d really appreciate any guidance or insights you could share.
I'll continue to look into it as time permits.:D
SanjayMarreddi commentedon Jul 3, 2025
Hi @guizmaii @JeonDaehong
Just saw this issue and wanted to let you know that we are adding support for the Netty and Crt Async clients as part of this PR!