Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 9ecc2be

Browse files
committedJun 18, 2025·
some changes per comments
1 parent 0bba5ef commit 9ecc2be

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed
 

‎arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPlainValuesReader.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@
2525

2626
class VectorizedPlainValuesReader extends ValuesAsBytesReader implements VectorizedValuesReader {
2727

28+
public static final int INT_SIZE = 4;
29+
public static final int LONG_SIZE = 8;
30+
public static final int FLOAT_SIZE = 4;
31+
public static final int DOUBLE_SIZE = 8;
32+
2833
VectorizedPlainValuesReader() {}
2934

3035
@Override
@@ -57,21 +62,21 @@ private void readValues(int total, FieldVector vec, int rowId, int typeWidth) {
5762

5863
@Override
5964
public void readIntegers(int total, FieldVector vec, int rowId) {
60-
readValues(total, vec, rowId, 4);
65+
readValues(total, vec, rowId, INT_SIZE);
6166
}
6267

6368
@Override
6469
public void readLongs(int total, FieldVector vec, int rowId) {
65-
readValues(total, vec, rowId, 8);
70+
readValues(total, vec, rowId, LONG_SIZE);
6671
}
6772

6873
@Override
6974
public void readFloats(int total, FieldVector vec, int rowId) {
70-
readValues(total, vec, rowId, 4);
75+
readValues(total, vec, rowId, FLOAT_SIZE);
7176
}
7277

7378
@Override
7479
public void readDoubles(int total, FieldVector vec, int rowId) {
75-
readValues(total, vec, rowId, 8);
80+
readValues(total, vec, rowId, DOUBLE_SIZE);
7681
}
7782
}

0 commit comments

Comments
 (0)
Please sign in to comment.