HIVE-28796: Remove transient from static fields (#5836)

Author: Aggarwal-Raghav

iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTransformSortFunctionUtil.java

@@ -50,7 +50,7 @@ private IcebergTransformSortFunctionUtil() {
    * Takes the source column index and the bucket count to create a function where Iceberg transform UDF is used to
    * build the sort expression, e.g. iceberg_bucket(_col2, 5)
    */
-  private static final transient BiFunction<Integer, Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
+  private static final BiFunction<Integer, Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
       BUCKET_SORT_EXPR =
           (idx, bucket) -> cols -> {
             try {
@@ -65,7 +65,7 @@ private IcebergTransformSortFunctionUtil() {
             }
           };
 
-  private static final transient BiFunction<Integer, Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
+  private static final BiFunction<Integer, Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
       TRUNCATE_SORT_EXPR =
           (idx, truncateLength) -> cols -> {
             try {
@@ -80,7 +80,7 @@ private IcebergTransformSortFunctionUtil() {
             }
           };
 
-  private static final transient Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
+  private static final Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
       YEAR_SORT_EXPR =
           idx -> cols -> {
             try {
@@ -94,7 +94,7 @@ private IcebergTransformSortFunctionUtil() {
             }
           };
 
-  private static final transient Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
+  private static final Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
       MONTH_SORT_EXPR =
           idx -> cols -> {
             try {
@@ -108,7 +108,7 @@ private IcebergTransformSortFunctionUtil() {
             }
           };
 
-  private static final transient Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
+  private static final Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
       DAY_SORT_EXPR =
           idx -> cols -> {
             try {
@@ -122,7 +122,7 @@ private IcebergTransformSortFunctionUtil() {
             }
           };
 
-  private static final transient Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
+  private static final Function<Integer, Function<List<ExprNodeDesc>, ExprNodeDesc>>
       HOUR_SORT_EXPR =
           idx -> cols -> {
             try {

ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxString.txt

@@ -51,7 +51,7 @@ public class <ClassName> extends VectorAggregateExpression {
 
       private static final long serialVersionUID = 1L;
 
-      transient private final static int MIN_BUFFER_SIZE = 16;
+      private final static int MIN_BUFFER_SIZE = 16;
       transient private byte[] bytes = new byte[MIN_BUFFER_SIZE];
       transient private int length;
 

ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java

@@ -71,7 +71,7 @@
 
 public class ColumnStatsUpdateTask extends Task<ColumnStatsUpdateWork> {
   private static final long serialVersionUID = 1L;
-  private static transient final Logger LOG = LoggerFactory
+  private static final Logger LOG = LoggerFactory
       .getLogger(ColumnStatsUpdateTask.class);
 
   private ColumnStatistics constructColumnStatsFromInput()

ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java

@@ -104,7 +104,7 @@
 public class MoveTask extends Task<MoveWork> implements Serializable {
 
   private static final long serialVersionUID = 1L;
-  private static transient final Logger LOG = LoggerFactory.getLogger(MoveTask.class);
+  private static final Logger LOG = LoggerFactory.getLogger(MoveTask.class);
   private final PerfLogger perfLogger = SessionState.getPerfLogger();
 
   public MoveTask() {

ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java

@@ -82,7 +82,7 @@
  */
 @SuppressWarnings({ "rawtypes", "unchecked" })
 public final class OperatorFactory {
-  protected static transient final Logger LOG = LoggerFactory.getLogger(OperatorFactory.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(OperatorFactory.class);
   private static final IdentityHashMap<Class<? extends OperatorDesc>,
     Class<? extends Operator<? extends OperatorDesc>>> opvec = new IdentityHashMap<>();
   private static final IdentityHashMap<Class<? extends OperatorDesc>,

ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java

@@ -52,7 +52,7 @@ public class ReplCopyTask extends Task<ReplCopyWork> implements Serializable {
 
   private static final long serialVersionUID = 1L;
 
-  private static transient final Logger LOG = LoggerFactory.getLogger(ReplCopyTask.class);
+  private static final Logger LOG = LoggerFactory.getLogger(ReplCopyTask.class);
 
   public ReplCopyTask() {
     super();

ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java

@@ -56,7 +56,7 @@
 
 public class StatsTask extends Task<StatsWork> implements Serializable {
   private static final long serialVersionUID = 1L;
-  private static transient final Logger LOG = LoggerFactory.getLogger(StatsTask.class);
+  private static final Logger LOG = LoggerFactory.getLogger(StatsTask.class);
   private final PerfLogger perfLogger = SessionState.getPerfLogger();
 
   public StatsTask() {

ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java

@@ -67,7 +67,7 @@ public abstract class Task<T extends Serializable> implements Serializable, Node
   protected transient String jobID;
   protected Task<?> backupTask;
   protected List<Task<?>> backupChildrenTasks = new ArrayList<Task<?>>();
-  protected static transient Logger LOG = LoggerFactory.getLogger(Task.class);
+  protected static Logger LOG = LoggerFactory.getLogger(Task.class);
   protected int taskTag;
   protected DeferredWorkContext deferredWorkContext;
   private boolean isLocalMode =false;

ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java

@@ -46,7 +46,7 @@ protected Long initialValue() {
 
   protected Thread runner;
 
-  private static transient final Logger LOG = LoggerFactory.getLogger(TaskRunner.class);
+  private static final Logger LOG = LoggerFactory.getLogger(TaskRunner.class);
 
   private final TaskQueue taskQueue;
 

ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java

@@ -124,7 +124,7 @@ public class ExecDriver extends Task<MapredWork> implements Serializable, Hadoop
   private transient boolean isShutdown = false;
   private transient boolean jobKilled = false;
 
-  protected static transient final Logger LOG = LoggerFactory.getLogger(ExecDriver.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(ExecDriver.class);
 
   private RunningJob rj;
 

ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java

@@ -99,7 +99,7 @@ public class MapredLocalTask extends Task<MapredLocalWork> implements Serializab
   private final Map<String, FetchOperator> fetchOperators = new HashMap<String, FetchOperator>();
   protected HadoopJobExecHelper jobExecHelper;
   private JobConf job;
-  public static transient final Logger l4j = LoggerFactory.getLogger(MapredLocalTask.class);
+  public static final Logger l4j = LoggerFactory.getLogger(MapredLocalTask.class);
   static final String HIVE_LOCAL_TASK_CHILD_OPTS_KEY = "HIVE_LOCAL_TASK_CHILD_OPTS";
   public static MemoryMXBean memoryMXBean;
   private static final Logger LOG = LoggerFactory.getLogger(MapredLocalTask.class);

ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java

@@ -65,7 +65,7 @@
  **/
 public class AtlasDumpTask extends Task<AtlasDumpWork> implements Serializable {
 
-  private static final transient Logger LOG = LoggerFactory.getLogger(AtlasDumpTask.class);
+  private static final Logger LOG = LoggerFactory.getLogger(AtlasDumpTask.class);
   private static final long serialVersionUID = 1L;
   private transient AtlasRestClient atlasRestClient;
 

ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasLoadTask.java

@@ -57,7 +57,7 @@
  **/
 public class AtlasLoadTask extends Task<AtlasLoadWork> implements Serializable {
   private static final long serialVersionUID = 1L;
-  private static final transient Logger LOG = LoggerFactory.getLogger(AtlasLoadTask.class);
+  private static final Logger LOG = LoggerFactory.getLogger(AtlasLoadTask.class);
 
   public AtlasLoadTask() {
     super();

ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplicationMigrationTool.java

@@ -52,7 +52,7 @@
 
 public class ReplicationMigrationTool implements Tool {
 
-  protected static transient Logger LOG = LoggerFactory.getLogger(ReplicationMigrationTool.class);
+  protected static Logger LOG = LoggerFactory.getLogger(ReplicationMigrationTool.class);
   private Configuration conf;
   private String help = "\tSample Usage: \n"
       + "hive --replMigration -dumpFilePath <path to external table info file> [-dirLevelCheck] "

ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/LoadDatabase.java

@@ -54,7 +54,7 @@ public class LoadDatabase {
   private final DatabaseEvent event;
   private final String dbNameToLoadIn;
   transient ReplicationMetricCollector metricCollector;
-  protected static transient Logger LOG = LoggerFactory.getLogger(LoadDatabase.class);
+  protected static Logger LOG = LoggerFactory.getLogger(LoadDatabase.class);
 
   public LoadDatabase(Context context, DatabaseEvent event, String dbNameToLoadIn, TaskTracker loadTaskTracker) {
     this.context = context;

ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java

@@ -180,7 +180,7 @@ public enum MetricName {
   public static final String DISTCP_JOB_ID_CONF = "distcp.job.id";
   public static final String DISTCP_JOB_ID_CONF_DEFAULT = "UNAVAILABLE";
 
-  private static transient Logger LOG = LoggerFactory.getLogger(ReplUtils.class);
+  private static Logger LOG = LoggerFactory.getLogger(ReplUtils.class);
 
   public static Map<Integer, List<ExprNodeGenericFuncDesc>> genPartSpecs(
           Table table, List<Map<String, String>> partitions) throws SemanticException {

ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/SnapshotUtils.java

@@ -45,7 +45,7 @@
  */
 public class SnapshotUtils {
 
-  private static final transient Logger LOG = LoggerFactory.getLogger(SnapshotUtils.class);
+  private static final Logger LOG = LoggerFactory.getLogger(SnapshotUtils.class);
 
   public static final String OLD_SNAPSHOT = "replOld";
   public static final String NEW_SNAPSHOT = "replNew";

ql/src/java/org/apache/hadoop/hive/ql/exec/tez/PerPoolTriggerValidatorRunnable.java

@@ -30,7 +30,7 @@
 import org.slf4j.LoggerFactory;
 
 public class PerPoolTriggerValidatorRunnable implements Runnable {
-  protected static transient Logger LOG = LoggerFactory.getLogger(PerPoolTriggerValidatorRunnable.class);
+  protected static Logger LOG = LoggerFactory.getLogger(PerPoolTriggerValidatorRunnable.class);
   private final Map<String, SessionTriggerProvider> sessionTriggerProviders;
   private final TriggerActionHandler triggerActionHandler;
   private final Map<String, TriggerValidatorRunnable> poolValidators;

ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java

@@ -109,7 +109,7 @@ public class TezTask extends Task<TezWork> {
   private static final String JOB_ID_TEMPLATE = "job_%s%d_%s";
   private static final String ICEBERG_PROPERTY_PREFIX = "iceberg.mr.";
   private static final String ICEBERG_SERIALIZED_TABLE_PREFIX = "iceberg.mr.serialized.table.";
-  private static transient Logger LOG = LoggerFactory.getLogger(CLASS_NAME);
+  private static Logger LOG = LoggerFactory.getLogger(CLASS_NAME);
   private final PerfLogger perfLogger = SessionState.getPerfLogger();
   private static final String TEZ_MEMORY_RESERVE_FRACTION = "tez.task.scale.memory.reserve-fraction";
 

ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TriggerValidatorRunnable.java

@@ -30,7 +30,7 @@
 import org.slf4j.LoggerFactory;
 
 public class TriggerValidatorRunnable implements Runnable {
-  protected static transient Logger LOG = LoggerFactory.getLogger(TriggerValidatorRunnable.class);
+  protected static Logger LOG = LoggerFactory.getLogger(TriggerValidatorRunnable.class);
   private final SessionTriggerProvider sessionTriggerProvider;
   private final TriggerActionHandler triggerActionHandler;
 

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnOrderedMap.java

@@ -36,7 +36,7 @@
  * Call getMapping to collects the results into convenient arrays.
  */
 public class VectorColumnOrderedMap {
-  protected static transient final Logger LOG = LoggerFactory.getLogger(VectorColumnOrderedMap.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(VectorColumnOrderedMap.class);
 
   protected String name;
 

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorCopyRow.java

@@ -31,7 +31,7 @@
  */
 public class VectorCopyRow {
 
-  protected static transient final Logger LOG = LoggerFactory.getLogger(VectorCopyRow.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(VectorCopyRow.class);
 
   private abstract class CopyRow {
     protected int inColumnIndex;

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColRegExpStringScalar.java

@@ -35,7 +35,7 @@ public class FilterStringColRegExpStringScalar extends AbstractFilterStringColLi
   private static final String LITERAL_CHAR = "[^\\[\\]\\\\(){}*?+|$^.]";
   private static final String LITERAL_CHAR_GROUP = "(" + LITERAL_CHAR + "+)";
 
-  private transient static List<CheckerFactory> checkerFactories = Arrays.asList(
+  private static List<CheckerFactory> checkerFactories = Arrays.asList(
       new CheckerFactory [] { new ComplexCheckerFactory() });
 
   public FilterStringColRegExpStringScalar() {

ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java

@@ -52,7 +52,7 @@ public class HiveOnTezCostModel extends HiveCostModel {
 
   private static HiveAlgorithmsUtil algoUtils;
 
-  private static transient final Logger LOG = LoggerFactory.getLogger(HiveOnTezCostModel.class);
+  private static final Logger LOG = LoggerFactory.getLogger(HiveOnTezCostModel.class);
 
   synchronized public static HiveOnTezCostModel getCostModel(HiveConf conf) {
     if (INSTANCE == null) {

ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java

@@ -60,7 +60,7 @@ public class HiveJoinToMultiJoinRule extends RelOptRule {
 
   private final ProjectFactory projectFactory;
 
-  private static transient final Logger LOG = LoggerFactory.getLogger(HiveJoinToMultiJoinRule.class);
+  private static final Logger LOG = LoggerFactory.getLogger(HiveJoinToMultiJoinRule.class);
 
   //~ Constructors -----------------------------------------------------------
 

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CrossProductHandler.java

@@ -80,7 +80,7 @@
  */
 public class CrossProductHandler implements PhysicalPlanResolver, SemanticDispatcher {
 
-  protected static transient final Logger LOG = LoggerFactory
+  protected static final Logger LOG = LoggerFactory
       .getLogger(CrossProductHandler.class);
   private Boolean cartesianProductEdgeEnabled = null;
 

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java

@@ -90,7 +90,7 @@
  */
 public class LlapDecider implements PhysicalPlanResolver {
 
-  protected static transient final Logger LOG = LoggerFactory.getLogger(LlapDecider.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(LlapDecider.class);
 
   private HiveConf conf;
 

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapPreVectorizationPass.java

@@ -49,7 +49,7 @@
  * For any LLAP-related transformations which need to occur before vectorization.
  */
 public class LlapPreVectorizationPass implements PhysicalPlanResolver {
-  protected static transient final Logger LOG = LoggerFactory.getLogger(LlapPreVectorizationPass.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(LlapPreVectorizationPass.class);
 
   @Override
   public PhysicalContext resolve(PhysicalContext pctx) throws SemanticException {

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MemoryDecider.java

@@ -62,7 +62,7 @@
  */
 public class MemoryDecider implements PhysicalPlanResolver {
 
-  protected static transient final Logger LOG = LoggerFactory.getLogger(MemoryDecider.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(MemoryDecider.class);
 
   public class MemoryCalculator implements SemanticDispatcher {
 

ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SerializeFilter.java

@@ -53,7 +53,7 @@
  */
 public class SerializeFilter implements PhysicalPlanResolver {
 
-  protected static transient final Logger LOG = LoggerFactory.getLogger(SerializeFilter.class);
+  protected static final Logger LOG = LoggerFactory.getLogger(SerializeFilter.class);
 
   public class Serializer implements SemanticDispatcher {
 

ql/src/java/org/apache/hadoop/hive/ql/plan/ExprDynamicParamDesc.java

@@ -39,7 +39,7 @@
  */
 public class ExprDynamicParamDesc extends ExprNodeDesc implements Serializable {
   private static final long serialVersionUID = 1L;
-  final protected transient static char[] hexArray = "0123456789ABCDEF".toCharArray();
+  final protected static char[] hexArray = "0123456789ABCDEF".toCharArray();
 
   private int index;
   private Object value;

ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java

@@ -40,7 +40,7 @@
  */
 public class ExprNodeConstantDesc extends ExprNodeDesc implements Serializable {
   private static final long serialVersionUID = 1L;
-  final protected transient static char[] hexArray = "0123456789ABCDEF".toCharArray();
+  final protected static char[] hexArray = "0123456789ABCDEF".toCharArray();
   private Object value;
   // If this constant was created while doing constant folding, foldedFromCol holds the name of
   // original column from which it was folded.

ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java

@@ -69,7 +69,7 @@ public static boolean isCustomInputType(VertexType vertex) {
     }
   }
 
-  private static transient final Logger LOG = LoggerFactory.getLogger(TezWork.class);
+  private static final Logger LOG = LoggerFactory.getLogger(TezWork.class);
 
   private static final AtomicInteger counter = new AtomicInteger(1);
   private final String dagId;

ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java

@@ -68,7 +68,7 @@
  */
 public class SyntheticJoinPredicate extends Transform {
 
-  private static transient Logger LOG = LoggerFactory.getLogger(SyntheticJoinPredicate.class.getName());
+  private static Logger LOG = LoggerFactory.getLogger(SyntheticJoinPredicate.class.getName());
 
   @Override
   public ParseContext transform(ParseContext pctx) throws SemanticException {

ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java

@@ -85,7 +85,7 @@
  **/
 public class BasicStatsNoJobTask implements IStatsProcessor {
 
-  private static transient final Logger LOG = LoggerFactory.getLogger(BasicStatsNoJobTask.class);
+  private static final Logger LOG = LoggerFactory.getLogger(BasicStatsNoJobTask.class);
   private HiveConf conf;
 
   private BasicStatsNoJobWork work;

ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java

@@ -65,7 +65,7 @@
 
 
 public class ColStatsProcessor implements IStatsProcessor {
-  private static transient final Logger LOG = LoggerFactory.getLogger(ColStatsProcessor.class);
+  private static final Logger LOG = LoggerFactory.getLogger(ColStatsProcessor.class);
 
   private FetchOperator ftOp;
   private FetchWork fWork;