Block API v3 Feedback

[jaymcp]

Feedback to be addressed:

Testing notes

• Action Block: Image appears distorted in the editor, button styles are incorrect (width and padding) for both editor and frontend, regardless of branding plugin activity. Alignment controls have no affect on the front end, and float in the editor
• Background Media BLOCK: does not render correctly and breaks when trying to add a BG image.
• Background Media PATTERN: no top padding on column inner blocks (frontend)
• Blockquote: core quote still hidden and missing styles, previous PR for reference: Adds Core Quote Block and Styles #326
• Buttons: Back link styles don't apply on the frontend, all buttons are pill shaped on the frontend. Default style when inserting button is off http://bigbite.im/i/6gwWem
• Collapsable/Details: details styles appear to be part of this PR (compare to original PR here, but do not seem to be applying at all http://bigbite.im/i/1iSWPw)
• Columns: custom columns block still insertable in the block inserter
• Countdown Timer: inspector controls looking a little wonky http://bigbite.im/i/La52p2
• Custom card pattern: button expands outside the card in the editor, image covers, but image position might need addressing (http://bigbite.im/i/dkYtCB)
• Resource Download: No padding on button, and block styles labelled incorrectly (http://bigbite.im/i/OejEbr), core/file is available in the block inserter, not sure if this should be hidden
• Fluid iFrame: seems to be missing button styles in the editor
• iFrame Button: nothing happens when clicking the button on the frontend, and dark styles seem to be missing frontend too
• Links with Icons Patterns: all buttons are justified to the left rather than the centre, square border style is missing, also has brand styles that I don't think belong on there (http://bigbite.im/i/bVwFgq)
• Menu Block: struggles to load menus making the block unusable (http://bigbite.im/v/44QVSQ)
• Regions: works as expected, but some changes are a step behind in the editor, namely changing taxonomy and subregions toggle
• Related Content: block breaks as soon as it is inserted into a post
• Slider block: block breaks as soon as it is inserted into a post
• Tweet Action: alternative style has no effect in the editor, Size dropdown appears to have no effect anywhere.
• Modal CTA: when opening the modal on the frontend, the entire contents of the dropdown is displayed (http://bigbite.im/i/k9qyLZ)
• Sidebar block: don't seem to be able to get the sidebar block to render on the front end
• Recipients block: dropdown displays over other content on the front end

Originally posted by @Gentyspun in #285

[jaymcp]

Action Block: Image appears distorted in the editor, button styles are incorrect (width and padding) for both editor and frontend, regardless of branding plugin activity. Alignment controls have no affect on the front end, and float in the editor

button styles were not marked as shared. resolved.
.editor-plain-text is now .block-editor-plain-text in 6.7.
this block didn't previously support in code any alignments other than default/centred, despite it declaring that it did in the block's settings. this has been fixed.

[jaymcp]

Background Media BLOCK: does not render correctly and breaks when trying to add a BG image.

there were a few issues with the render that have been fixed.

[jaymcp]

Background Media PATTERN: no top padding on column inner blocks (frontend)

these patterns have been modified.

[jaymcp]

Buttons: Back link styles don't apply on the frontend, all buttons are pill shaped on the frontend. Default style when inserting button is off http://bigbite.im/i/6gwWem

Fixed in https://github.com/amnestywebsite/wp-plugin-amnesty-branding/pull/65

[jaymcp]

Collapsable/Details: details styles appear to be part of this PR (compare to original PR #240, but do not seem to be applying at all http://bigbite.im/i/1iSWPw)

Fixed in 9788d59

[jaymcp]

Columns: custom columns block still insertable in the block inserter

fixed in 7a2ab0f

[jaymcp]

Countdown Timer: inspector controls looking a little wonky http://bigbite.im/i/La52p2

this appears to be some weirdity with the block editor. shoehorned a fix in 8dfb808. this also adds missing block props.

[jaymcp]

Custom card pattern: button expands outside the card in the editor, image covers, but image position might need addressing (http://bigbite.im/i/dkYtCB)

fixed in dcba3ca