fix(helpers): Fix prototype construction (#561)

* Return ["String"] as protochain part when object type is "Literal"

* Update compat data

* Only return "String" if the literal is a string literal

* Return "Array" for "ArrayExpression"

Author: koddsson

package-lock.json

@@ -83,10 +83,10 @@
     "semi": true
   },
   "dependencies": {
-    "@mdn/browser-compat-data": "^5.2.34",
-    "ast-metadata-inferer": "^0.7.0",
+    "@mdn/browser-compat-data": "^5.2.47",
+    "ast-metadata-inferer": "^0.8.0",
     "browserslist": "^4.21.5",
-    "caniuse-lite": "^1.0.30001451",
+    "caniuse-lite": "^1.0.30001473",
     "find-up": "^5.0.0",
     "lodash.memoize": "4.1.2",
     "semver": "7.3.8"

package.json

@@ -91,15 +91,24 @@ export function lintExpressionStatement(
     );
 }
 
+function isStringLiteral(node: ESLintNode): boolean {
+  return node.type === "Literal" && typeof node.value === "string";
+}
+
 function protoChainFromMemberExpression(node: ESLintNode): string[] {
   if (!node.object) return [node.name];
   const protoChain = (() => {
-    switch (node.object.type) {
-      case "NewExpression":
-      case "CallExpression":
-        return protoChainFromMemberExpression(node.object.callee!);
-      default:
-        return protoChainFromMemberExpression(node.object);
+    if (
+      node.object.type === "NewExpression" ||
+      node.object.type === "CallExpression"
+    ) {
+      return protoChainFromMemberExpression(node.object.callee!);
+    } else if (node.object.type === "ArrayExpression") {
+      return ["Array"];
+    } else if (isStringLiteral(node.object)) {
+      return ["String"];
+    } else {
+      return protoChainFromMemberExpression(node.object);
     }
   })();
   return [...protoChain, node.property!.name];

src/helpers.ts

@@ -39,6 +39,7 @@ export type TargetNames = Array<string>;
 export type ESLintNode = {
   name: string;
   type: string;
+  value?: unknown;
   object?: ESLintNode;
   parent?: ESLintNode;
   expression?: ESLintNode;