Skip to content

Commit 557979b

Browse files
author
Gianluca Varisco
committed
Update the right syntax for flag '--window-size' as per its original reference: https://cs.chromium.org/chromium/src/headless/app/headless_shell_switches.cc?l=109
PR #91 partially implemented the change, I've just amended it in the missing places.
1 parent 915013d commit 557979b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

examples/serverless-framework/aws/serverless.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ plugins:
1717
custom:
1818
chrome:
1919
flags:
20-
- --window-size=1280x1696 # Letter size
20+
- --window-size=1280,1696 # Letter size
2121
- --hide-scrollbars
2222

2323
functions:

packages/lambda/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const CDP = require('chrome-remote-interface')
4444

4545
module.exports.handler = function handler (event, context, callback) {
4646
launchChrome({
47-
flags: ['--window-size=1280x1696', '--hide-scrollbars']
47+
flags: ['--window-size=1280,1696', '--hide-scrollbars']
4848
})
4949
.then((chrome) => {
5050
// Chrome is now running on localhost:9222

packages/serverless-plugin/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ plugins:
9797
custom:
9898
chrome:
9999
flags:
100-
- --window-size=1280x1696 # Letter size
100+
- --window-size=1280,1696 # Letter size
101101
- --hide-scrollbars
102102
- --ignore-certificate-errors
103103
functions:

packages/serverless-plugin/integration-test/serverless.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ plugins:
1515
custom:
1616
chrome:
1717
flags:
18-
- --window-size=1280x1696 # Letter size
18+
- --window-size=1280,1696 # Letter size
1919
- --hide-scrollbars
2020
- --ignore-certificate-errors
2121
functions:

0 commit comments

Comments
 (0)