Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gitim/react-native-sortable-list
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: adamhari/react-native-sortable-list
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 18, 2019

  1. remove usages of this._prevSwapedRowKey to fix issue where swapping t…

    …wo rows back and forth resulted in inconsistent drag behaviour
    Adam-Hari committed Sep 18, 2019
    Copy the full SHA
    2d64c23 View commit details
  2. add back this._prevSwapedRowKey, change _onReleaseRow to null out thi…

    …s._prevSwapedRowKey
    Adam-Hari committed Sep 18, 2019
    Copy the full SHA
    53dde92 View commit details
Showing with 1 addition and 0 deletions.
  1. +1 −0 src/SortableList.js
1 change: 1 addition & 0 deletions src/SortableList.js
Original file line number Diff line number Diff line change
@@ -590,6 +590,7 @@ export default class SortableList extends Component {
};

_onReleaseRow = (rowKey) => {
this._prevSwapedRowKey = null;
this._stopAutoScroll();
this.setState(({activeRowKey}) => ({
activeRowKey: null,