percent encode password in constructed url string (#173)

* percent encode password in constructed url string

* comments

Author: achristmascarl

Cargo.lock

@@ -90,6 +90,7 @@ rpassword = "7.3.1"
 async-trait = "0.1.83"
 dotenvy = "0.15.7"
 csv = "1.3.1"
+percent-encoding = "2.3.1"
 
 [target.'cfg(any(target_os = "macos", target_os = "ios", target_os = "android"))'.dependencies]
 keyring = { version = "3.6.2", features = [

Cargo.toml

@@ -3,11 +3,44 @@ use std::{collections::HashMap, path::PathBuf};
 use color_eyre::eyre::{self, Result};
 use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
 use derive_deref::{Deref, DerefMut};
+use percent_encoding::{utf8_percent_encode, AsciiSet, CONTROLS};
 use ratatui::style::{Color, Modifier, Style};
 use serde::{de::Deserializer, Deserialize};
 
 use crate::{action::Action, cli::Driver, focus::Focus, keyring::Password};
 
+// percent encoding for passwords in connection strings
+const FRAGMENT: &AsciiSet = &CONTROLS
+  .add(b' ')
+  .add(b'"')
+  .add(b'<')
+  .add(b'>')
+  .add(b'`')
+  .add(b'#')
+  .add(b'{')
+  .add(b'}')
+  .add(b'|')
+  .add(b'^')
+  .add(b'\\')
+  .add(b'[')
+  .add(b']')
+  .add(b'$')
+  .add(b'&')
+  .add(b'(')
+  .add(b')')
+  .add(b':')
+  .add(b';')
+  .add(b'=')
+  .add(b'?')
+  .add(b'@')
+  .add(b'!')
+  .add(b'~')
+  .add(b'\'')
+  .add(b'*')
+  .add(b'+')
+  .add(b',')
+  .add(b'/');
+
 const CONFIG: &str = include_str!("../.config/rainfrog_config.toml");
 
 #[derive(Clone, Debug, Deserialize, Default)]
@@ -65,17 +98,13 @@ pub struct Config {
 
 impl StructuredConnection {
   pub fn connection_string(&self, driver: Driver, password: Password) -> Result<String> {
+    let encoded_password = utf8_percent_encode(password.as_ref(), FRAGMENT);
     match driver {
-      Driver::Postgres => Ok(format!(
-        "postgresql://{}:{}@{}:{}/{}",
-        self.username,
-        password.as_ref(),
-        self.host,
-        self.port,
-        self.database
-      )),
+      Driver::Postgres => {
+        Ok(format!("postgresql://{}:{}@{}:{}/{}", self.username, encoded_password, self.host, self.port, self.database))
+      },
       Driver::MySql => {
-        Ok(format!("mysql://{}:{}@{}:{}/{}", self.username, password.as_ref(), self.host, self.port, self.database))
+        Ok(format!("mysql://{}:{}@{}:{}/{}", self.username, encoded_password, self.host, self.port, self.database))
       },
       Driver::Sqlite => Err(eyre::Report::msg("Sqlite only supports raw connection strings")),
     }