Skip to content

Commit 5a0e2cc

Browse files
author
Gilad Weinbach
committed
feat(k8s-values): enable Prometheus metrics
fix indent in template
1 parent 36d1a42 commit 5a0e2cc

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

helm/spark-yotpo/templates/sparkapplication.yaml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -138,18 +138,18 @@ spec:
138138
{{ toYaml .Values.tolerations | indent 6 }}
139139
{{- end }}
140140
{{- if .Values.jmxExporterJar }}
141-
monitoring:
142-
exposeDriverMetrics: true
143-
exposeExecutorMetrics: true
144-
prometheus:
145-
port: {{ .Values.jmxPort | default 8090 }}
146-
jmxExporterJar: {{ .Values.jmxExporterJar }}
147-
{{- end }}
148-
{{- if .Values.volumes }}
149-
volumes:
150-
{{ toYaml .Values.volumes | indent 3 }}
151-
{{- end }}
152-
{{- if .Values.nodeSelector }}
153-
nodeSelector:
154-
{{ toYaml .Values.nodeSelector | indent 4 }}
155-
{{- end }}
141+
monitoring:
142+
exposeDriverMetrics: true
143+
exposeExecutorMetrics: true
144+
prometheus:
145+
port: {{ .Values.jmxPort | default 8090 }}
146+
jmxExporterJar: {{ .Values.jmxExporterJar }}
147+
{{- end }}
148+
{{- if .Values.volumes }}
149+
volumes:
150+
{{ toYaml .Values.volumes | indent 3 }}
151+
{{- end }}
152+
{{- if .Values.nodeSelector }}
153+
nodeSelector:
154+
{{ toYaml .Values.nodeSelector | indent 4 }}
155+
{{- end }}

helm/spark-yotpo/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ executor:
1919
coreLimit: 1
2020
instances: 1
2121
memory: "512m"
22+
jmxExporterJar: "/prometheus/jmx_prometheus_javaagent-0.11.0.jar"
2223
sparkConf:
2324
spark.executor.logs.rolling.maxRetainedFiles: 0
2425
spark.executor.logs.rolling.maxSize: 104857600

0 commit comments

Comments
 (0)