Merge pull request #2035 from hbhalodia/feat/issue-2031

Effective asset cache headers audit should not fail when on local/development environments

Author: westonruter

plugins/performance-lab/includes/site-health/effective-asset-cache-headers/hooks.php

@@ -22,10 +22,18 @@
  * @return array{direct: array<string, array{label: string, test: string}>} Amended tests.
  */
 function perflab_effective_asset_cache_headers_add_test( array $tests ): array {
-	$tests['direct']['effective_asset_cache_headers'] = array(
-		'label' => __( 'Effective Caching Headers', 'performance-lab' ),
-		'test'  => 'perflab_effective_asset_cache_headers_assets_test',
-	);
+	/*
+	 * Static assets are expected to not have effective cache headers in non-production environments.
+	 *
+	 * GH Issue: https://github.com/WordPress/performance/issues/2031
+	 */
+	if ( ! in_array( wp_get_environment_type(), array( 'local', 'development' ), true ) ) {
+		$tests['direct']['effective_asset_cache_headers'] = array(
+			'label' => __( 'Effective Caching Headers', 'performance-lab' ),
+			'test'  => 'perflab_effective_asset_cache_headers_assets_test',
+		);
+	}
+
 	return $tests;
 }
 add_filter( 'site_status_tests', 'perflab_effective_asset_cache_headers_add_test' );

plugins/performance-lab/tests/includes/site-health/effective-asset-cache-headers/test-effective-asset-cache-headers.php

@@ -40,9 +40,7 @@ public function test_perflab_effective_asset_cache_headers_add_test(): void {
 
 		$tests = perflab_effective_asset_cache_headers_add_test( $tests );
 
-		$this->assertArrayHasKey( 'effective_asset_cache_headers', $tests['direct'] );
-		$this->assertEquals( 'Effective Caching Headers', $tests['direct']['effective_asset_cache_headers']['label'] );
-		$this->assertEquals( 'perflab_effective_asset_cache_headers_assets_test', $tests['direct']['effective_asset_cache_headers']['test'] );
+		$this->assertArrayNotHasKey( 'effective_asset_cache_headers', $tests['direct'] );
 	}
 
 	/**