Improve PNG type checking

b1ink0 · b1ink0 · commit 7443e686a89f · 2025-06-10T16:45:41.000+05:30
diff --git a/plugins/webp-uploads/hooks.php b/plugins/webp-uploads/hooks.php
@@ -822,8 +822,11 @@ function webp_uploads_convert_palette_png_to_truecolor( $file ): array {
 	if ( ! isset( $file['tmp_name'], $file['name'] ) ) {
 		return $file;
 	}
-
-	if ( 'png' !== strtolower( pathinfo( $file['name'], PATHINFO_EXTENSION ) ) ) {
+	if ( isset( $file['type'] ) && is_string( $file['type'] ) ) {
+		if ( 'image/png' !== strtolower( $file['type'] ) ) {
+			return $file;
+		}
+	} elseif ( 'image/png' !== wp_check_filetype( $file['name'] )['type'] ) {
 		return $file;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -822,8 +822,11 @@ function webp_uploads_convert_palette_png_to_truecolor( $file ): array {`
`822`	`822`	`if ( ! isset( $file['tmp_name'], $file['name'] ) ) {`
`823`	`823`	`return $file;`
`824`	`824`	`}`
`825`		`-`
`826`		`- if ( 'png' !== strtolower( pathinfo( $file['name'], PATHINFO_EXTENSION ) ) ) {`
	`825`	`+ if ( isset( $file['type'] ) && is_string( $file['type'] ) ) {`
	`826`	`+ if ( 'image/png' !== strtolower( $file['type'] ) ) {`
	`827`	`+ return $file;`
	`828`	`+ }`
	`829`	`+ } elseif ( 'image/png' !== wp_check_filetype( $file['name'] )['type'] ) {`
`827`	`830`	`return $file;`
`828`	`831`	`}`
`829`	`832`