-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
[Feature] ExtensibilityThe ability to extend blocks or the editing experienceThe ability to extend blocks or the editing experience[Package] Editor/packages/editor/packages/editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Status] In discussionUsed to indicate that an issue is in the process of being discussedUsed to indicate that an issue is in the process of being discussed[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Description
What problem does this address?
Right now, PostLockedModal
is considered a crucial component of the editor and hence its tightly coupled. But with upcoming collaborating editing work in Gutenberg, this would change and since initially this work would be done outside in a plugin, we need the ability to cleanly unhook PostLockedModal
.
What is your proposed solution?
Decouple it and make it use Gutenberg's API to register itself registerPlugin()
, so that externally, we can cleanly remove the component.
Adi-ty
Metadata
Metadata
Assignees
Labels
[Feature] ExtensibilityThe ability to extend blocks or the editing experienceThe ability to extend blocks or the editing experience[Package] Editor/packages/editor/packages/editor[Status] In ProgressTracking issues with work in progressTracking issues with work in progress[Status] In discussionUsed to indicate that an issue is in the process of being discussedUsed to indicate that an issue is in the process of being discussed[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
t-hamano commentedon Jun 27, 2025
Thanks for the suggestion.
From what I understand, collaborative editing will be developed as an experimental feature within the Gutenberg plugin.
See https://github.com/WordPress/gutenberg/pull/68483/files#diff-f08775783077295e710976c98cf7c33a043dac17978aedd634ee0eb7021e80ce.
Additionally, this discussion may be helpful: #65012
ashfame commentedon Jun 27, 2025
Hi, I am aware of the context. There are two parallel efforts in exploration currently which would require this. Hence, created this issue.
Mamaduka commentedon Jun 30, 2025
Since the initial work will be done by a separate plugin that needs to replace the component, it may be better to use a filter. Something similar to
editor.PostFeaturedImage
.Pros
Cons.
P.S. I'm less worried about the cons; worst-case scenario, we can deprecate the
PostLockedModal
and filter when a better API becomes available.cc @WordPress/gutenberg-core
youknowriad commentedon Jul 1, 2025
I'm ok with filters but I think it needs to be limited to the Gutenberg plugin (using the variable) to avoid shipping the filter to Core at the moment.
Mamaduka commentedon Jul 1, 2025
That makes sense 👍. I'll put the PR together.