NamingConventions/ValidVariableName: allow for PHP 8.4 properties in interfaces

jrfnl · jrfnl · commit c7022ad486dc · 2025-06-14T13:23:41.000+02:00
diff --git a/WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.inc b/WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.inc
@@ -189,7 +189,7 @@ class MultiVarDeclarations {
 
 echo "This is $post_ID with $ThisShouldBeFlagged"; // Bad.
 
-// Safeguard that illegal property declarations are ignored.
+// Properties in interfaces are allowed since PHP 8.4.
 interface PropertiesNotAllowed {
 	public $notAllowed;
 }
diff --git a/WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.php b/WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.php
@@ -84,6 +84,7 @@ public function getErrorList() {
 			184 => 1,
 			186 => 1,
 			190 => 1,
+			194 => 1,
 			199 => 1,
 			200 => 1,
 			202 => 1,

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ class MultiVarDeclarations {`
`189`	`189`
`190`	`190`	`echo "This is $post_ID with $ThisShouldBeFlagged"; // Bad.`
`191`	`191`
`192`		`-// Safeguard that illegal property declarations are ignored.`
	`192`	`+// Properties in interfaces are allowed since PHP 8.4.`
`193`	`193`	`interface PropertiesNotAllowed {`
`194`	`194`	`public $notAllowed;`
`195`	`195`	`}`
-Original file line number
+Diff line change
 => 1,
 => 1,
 => 1,
 +			194 => 1,
 => 1,
 => 1,
 => 1,