Skip to content

WHS.ResizeModule does not play nicely with WHS.PostProcessorModule #389

Open
@antoniocapelo

Description

@antoniocapelo

Describe your issue here.

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion

Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera

I was having troubles getting the scene to keep its ratio and definition on screen resizes, even though I was using the WHS.ResizeModule with the default options.

I just discovered the issue: I'm using the WHS.PostProcessorModule to add some passes and internally it uses the EffectsComposer which creates a new renderer.

This renderer is a different instance from the one that's being updated on the ResizeModule setSize method.

Not really sure if this is a bug (since I'm guessing there's not a direct fix — the manager cannot return the correct renderer, since the order of the modules is relevant), but at least there could be some note on the WHS.PostProcessorModule Documentation, warning about this scenario.

I'm willing to contribute with a PR if needed.

Cheers

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions