-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[TT-15196] fix docs issue #7277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Knock Knock! 🔍 Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR. An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️
Check out this guide to learn more about PR best-practices. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
API Changes --- prev.txt 2025-08-06 10:54:59.388838570 +0000
+++ current.txt 2025-08-06 10:54:50.191909715 +0000
@@ -4488,6 +4488,7 @@
Example:
+ ```
{
"proxy_url": "http(s)://proxy.url:1234",
"minVersion": "1.0",
@@ -4499,6 +4500,7 @@
"insecureSkipVerify": true,
"forceCommonNameCheck": false
}
+ ```
Tyk classic API definition: `proxy.transport`
|
Code Review: PR #7277 - Fix Docs IssueOverviewThis PR makes a small but valuable documentation improvement by adding code block markers (triple backticks) to the TLSTransport struct documentation example in ChangesThe PR adds triple backticks (```) around the JSON example in the TLSTransport struct documentation: Example:
+ ```
{
"proxy_url": "http(s)://proxy.url:1234",
"minVersion": "1.0",
"maxVersion": "1.3",
"cipherSuites": [
"TLS_RSA_WITH_AES_128_GCM_SHA256",
"TLS_RSA_WITH_AES_256_GCM_SHA384"
],
"insecureSkipVerify": true,
"forceCommonNameCheck": false
}
+ ``` AnalysisDocumentation QualityThe addition of code block markers (```) around the JSON example is a good improvement that:
ImpactThis change is purely documentation-related and has no functional impact on the codebase. It only affects how the documentation is rendered when generated. Backward CompatibilityThere are no backward compatibility concerns as this change only affects documentation. ConclusionThis is a straightforward documentation improvement that enhances the readability of the API documentation. The changes are minimal, focused, and follow best practices for Go documentation. The PR is safe to merge as it only affects documentation comments and has no impact on the actual code behavior or API functionality. Tip: Mention me again using |
|
User description
TT-15196
This PR fixes an issue with generated docs.
PR Type
Documentation
Description
Added code block markers to TLSTransport documentation example
Improved clarity and formatting of GoDoc comments
Diagram Walkthrough
File Walkthrough
upstream.go
Add code block markers to TLSTransport GoDoc example
apidef/oas/upstream.go