Skip to content

Commit c3334fa

Browse files
committed
fix EventCertificateExpiringSoonMeta fields
1 parent f6578ae commit c3334fa

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

gateway/event_system.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,12 @@ type EventTokenMeta struct {
118118
// EventCertificateExpiringSoonMeta is the metadata structure for certificate expiration events
119119
type EventCertificateExpiringSoonMeta struct {
120120
EventMetaDefault
121-
CertificateID string `json:"certificate_id"`
122-
CertificateName string `json:"certificate_name"`
123-
ExpirationDate time.Time `json:"expiration_date"`
124-
DaysUntilExpiry int `json:"days_until_expiry"`
125-
APIID string `json:"api_id"`
126-
OrgID string `json:"org_id"`
121+
CertID string `json:"cert_id"`
122+
CertName string `json:"cert_name"`
123+
ExpiresAt time.Time `json:"expires_at"`
124+
DaysRemaining int `json:"days_remaining"`
125+
APIID string `json:"api_id"`
126+
OrgID string `json:"org_id"`
127127
}
128128

129129
// EventHandlerByName is a convenience function to get event handler instances from an API Definition

gateway/mw_certificate_check.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -344,12 +344,12 @@ func (m *CertificateCheckMW) fireCertificateExpiringSoonEvent(cert *tls.Certific
344344
EventMetaDefault: EventMetaDefault{
345345
Message: message,
346346
},
347-
CertificateID: certID,
348-
CertificateName: cert.Leaf.Subject.CommonName,
349-
ExpirationDate: cert.Leaf.NotAfter,
350-
DaysUntilExpiry: daysUntilExpiry,
351-
APIID: m.Spec.APIID,
352-
OrgID: m.Spec.OrgID,
347+
CertID: certID,
348+
CertName: cert.Leaf.Subject.CommonName,
349+
ExpiresAt: cert.Leaf.NotAfter,
350+
DaysRemaining: daysUntilExpiry,
351+
APIID: m.Spec.APIID,
352+
OrgID: m.Spec.OrgID,
353353
}
354354

355355
log.Debugf("Certificate expiry monitor: Firing expiry event for certificate '%s' - expires in %dd %dh (ID: %s...)", cert.Leaf.Subject.CommonName, daysUntilExpiry, remainingHours, certID[:8])

gateway/mw_certificate_check_integration_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ func TestCertificateCheckMW_Integration_CoreFunctionality(t *testing.T) {
306306
if len(events) > 0 {
307307
eventMeta, ok := events[0].Meta.(EventCertificateExpiringSoonMeta)
308308
assert.True(t, ok, "Event metadata should be EventCertificateExpiringSoonMeta")
309-
assert.Equal(t, "expiring.example.com", eventMeta.CertificateName, "Certificate name should match")
309+
assert.Equal(t, "expiring.example.com", eventMeta.CertName, "Certificate name should match")
310310
assert.Equal(t, "integration-test-api-id", eventMeta.APIID, "API ID should match")
311311
assert.Equal(t, "integration-test-org-id", eventMeta.OrgID, "Org ID should match")
312312
}
@@ -344,7 +344,7 @@ func TestCertificateCheckMW_Integration_CoreFunctionality(t *testing.T) {
344344
if len(events) > 0 {
345345
eventMeta, ok := events[0].Meta.(EventCertificateExpiringSoonMeta)
346346
assert.True(t, ok, "Event metadata should be EventCertificateExpiringSoonMeta")
347-
assert.Equal(t, "critical.example.com", eventMeta.CertificateName, "Certificate name should match")
347+
assert.Equal(t, "critical.example.com", eventMeta.CertName, "Certificate name should match")
348348
}
349349
})
350350

@@ -378,7 +378,7 @@ func TestCertificateCheckMW_Integration_CoreFunctionality(t *testing.T) {
378378
for _, e := range events {
379379
eventMeta, ok := e.Meta.(EventCertificateExpiringSoonMeta)
380380
assert.True(t, ok, "Event metadata should be EventCertificateExpiringSoonMeta")
381-
certNames[eventMeta.CertificateName] = true
381+
certNames[eventMeta.CertName] = true
382382
}
383383

384384
// Should have events for expiring and critical certificates, but not valid

0 commit comments

Comments
 (0)