Too concrete fromServices method name in ConfigRetrieverInterface

[antonkomarev]

Issue / Motivation:

I have to overwrite ConfigRetriever with my own implementation as I've described in #133.

I've created my own CustomConfigRetriever class and when started to implement ConfigRetrieverInterface understood that resolving method must be named fromServices. From my point of view it's too concrete name, because config might be stored not in services config file.

Proposed solution:

Rename it to something more generalized:

• retrieve
• resolve
• get
• forProvider
• ??? (any other name)

return resolve(ConfigRetrieverInterface::class)->forProvider(
    $providerName, $providerClass::additionalConfigKeys()
);

Obviously, it's breaking change.

[m1guelpf]

Can we make this non-breaking in some way?

[antonkomarev]

Manager is using SemVer, so we could just make it in the next major version. Nothing bad would happen, it's just future ideas. Changing contract is always breaking change ^_^

[m1guelpf]

Ok, then feel free to PR it with the name you prefer :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.