Attempted access on private property

[adam-winfree]

Issue

In SocialiteProviders\Manager\Helpers\ConfigRetriever.php:159, there is an attempt to access (and alter) the private property SocialiteProviders\Manager\SocialiteWasCalled::$spoofedConfig

Proposed solution

Honestly, I'm not sure how you want to handle this. I'm not particularly familiar with the repo. Just the messenger. Thanks for writing/providing the code, though!

[bmatt468]

Hey @adam-winfree,
I was having issues with this as well, so I created a fork of this project, and made a change there to hopefully get it working (at least it was in my instance). Before it gets patched here (which hopefully will happen soon. #111 references this issue), feel free to use my fork. To use it, add the following to your composer.json somewhere:

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/bmatt468/Manager"
    }
]

and then run composer update. You should see that the manager was updated to v3.3.1. Alternatively, you could fork it yourself, and make the same change.

[faustbrian]

Why do you need to fork it instead of sending a PR so everyone can benefit from a fix?

[bmatt468]

Ease of use honestly. #111 was already made, and closed because you were short on time (which is completely understandable. Managing an open source project can be a hassle, I would imagine).

Since it was a breaking change, I just pitched out a quick workaround for the time being, and I didn't want to make a duplicate pull, and "claim credit" where someone else had already done the work.

Quick Edit:
Also, I don't know the inner guts of Manager super well. I'm sure there was a necessary reason for the variable to be private vs public static. I didn't have time to dig through and properly get everything to work with the private variable, so it could be argued from y'all's side that changing the scope to just public is a little too "hacky". I hope that makes sense.

[faustbrian]

I tagged v3.3.1 which contains all changes that were the reason for it to be private. It uses to be public static because it was accessed by other classes without being injected but now is only used inside the class itself.

There is quite a bit of refactoring I would like to do, hope to find some time for that soon.