Skip to content

Commit f79184c

Browse files
committed
Implement review suggestions
1 parent 20a16f6 commit f79184c

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

app/src/main/java/free/rm/skytube/gui/businessobjects/SubscriptionsBackupsManager.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import android.os.Build;
1212
import android.os.Environment;
1313
import android.provider.OpenableColumns;
14-
import android.system.Os;
1514
import android.text.SpannableString;
1615
import android.text.util.Linkify;
1716
import android.util.Log;

app/src/test/java/free/rm/skytube/businessobjects/opml/OpmlExporterTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void testDefaultExportFileName() {
8383
public void testGenerateOpmlCorrect() throws ParserConfigurationException, IOException, SAXException {
8484
String opmlContent = OpmlExporter.generateOpmlContent(testChannels);
8585

86-
isOpmlIsValidXml(opmlContent, 3);
86+
assertOpmlIsValidXml(opmlContent, 3);
8787

8888
// Test that outline elements have correct structure
8989
Assertions.assertTrue(opmlContent.contains("type=\"rss\""),
@@ -146,7 +146,7 @@ public void testXmlEscapingFunction() {
146146
public void testEmptyChannelList() throws ParserConfigurationException, IOException, SAXException {
147147
List<YouTubeChannel> emptyList = new ArrayList<>();
148148
String opmlContent = OpmlExporter.generateOpmlContent(emptyList);
149-
isOpmlIsValidXml(opmlContent, 0);
149+
assertOpmlIsValidXml(opmlContent, 0);
150150

151151
// Should still generate valid OPML structure even with no channels
152152
Assertions.assertTrue(opmlContent.startsWith("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"),
@@ -162,14 +162,14 @@ public void testChannelWithNullTitle() throws ParserConfigurationException, IOEx
162162
List<YouTubeChannel> channelsWithNull = List.of(new MockYouTubeChannel("UC123", null));
163163

164164
String opmlContent = OpmlExporter.generateOpmlContent(channelsWithNull);
165-
isOpmlIsValidXml(opmlContent, 1);
165+
assertOpmlIsValidXml(opmlContent, 1);
166166

167167
// Should use "" for null titles
168168
Assertions.assertTrue(opmlContent.contains("text=\"\""),
169169
"Should use empty string for null channel titles");
170170
}
171171

172-
private void isOpmlIsValidXml(String opmlContent, int numberOfChannels) throws ParserConfigurationException, IOException, SAXException {
172+
private void assertOpmlIsValidXml(String opmlContent, int numberOfChannels) throws ParserConfigurationException, IOException, SAXException {
173173
// Validate that the generated OPML is valid XML
174174
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
175175
DocumentBuilder builder = factory.newDocumentBuilder();

0 commit comments

Comments
 (0)