check server uuid when getting online

Author: Nico-Duduf

src/ramdatainterface/dbinterface.cpp

@@ -46,7 +46,7 @@ void DBInterface::setOffline()
     pm->finish();
 }
 
-void DBInterface::setOnline()
+void DBInterface::setOnline(QString serverUuid)
 {
     if (m_ldi->dataFile() == "")
     {
@@ -60,7 +60,7 @@ void DBInterface::setOnline()
     }
 
     // Connects to the Ramses Server and change connection status
-    m_rsi->setOnline();
+    m_rsi->setOnline(serverUuid);
 }
 
 void DBInterface::setRamsesPath(QString p)
@@ -146,13 +146,16 @@ void DBInterface::setDataFile(const QString &file, bool ignoreUser)
         m_rsi->setServerPort(config.port);
         m_updateFrequency = config.updateDelay;
 
+        // Get the serverUuid we should be connecting to
+        QString serverUuid = m_ldi->serverUuid();
+
         // Check the user
         QString userUuid = m_ldi->currentUserUuid();
 
         qDebug() << "Selected previous user: " << userUuid;
 
         emit userChanged( userUuid );
-        setOnline();
+        setOnline(serverUuid);
 
         pm->setText(tr("Ready!"));
         pm->finish();
@@ -356,6 +359,7 @@ void DBInterface::connectEvents()
     connect(m_rsi, &RamServerInterface::connectionStatusChanged, this, &DBInterface::serverConnectionStatusChanged);
     connect(m_rsi, &RamServerInterface::syncReady, m_ldi, &LocalDataInterface::sync);
     connect(m_rsi, &RamServerInterface::userChanged, this, &DBInterface::serverUserChanged);
+    connect(m_rsi, &RamServerInterface::pong, m_ldi, &LocalDataInterface::setServerUuid);
     connect(m_updateTimer, SIGNAL(timeout()), this, SLOT(sync()));
 
     connect(qApp, &QApplication::aboutToQuit, this, &DBInterface::quit);

src/ramdatainterface/dbinterface.h

@@ -97,7 +97,7 @@ public slots:
     /**
      * @brief Changes to online mode.
      */
-    void setOnline();
+    void setOnline(QString serverUuid = "");
     // MAINTENANCE //
     QString cleanDabaBase(int deleteDataOlderThan = -1);
     bool undoClean();

src/ramdatainterface/localdatainterface.cpp

@@ -382,6 +382,23 @@ ServerConfig LocalDataInterface::serverConfig()
     return config;
 }
 
+void LocalDataInterface::setServerUuid(QString serverUuid)
+{
+    QString q = "UPDATE _Sync SET uuid = '%1';";
+    query( q.arg(serverUuid) );
+}
+
+QString LocalDataInterface::serverUuid()
+{
+    QString q = "SELECT uuid FROM _Sync;";
+    QSqlQuery qry = query( q );
+    QString uuid = "";
+    if (qry.first()) {
+        uuid = qry.value(0).toString();
+    }
+    return uuid;
+}
+
 QString LocalDataInterface::ramsesPath()
 {
     QString q = "SELECT path FROM _Paths WHERE name = 'Ramses';";
@@ -740,7 +757,7 @@ void LocalDataInterface::setCurrentUserUuid(QString uuid)
     query( q.arg(uuid) );
 }
 
-void LocalDataInterface::sync(QJsonObject data)
+void LocalDataInterface::sync(QJsonObject data, QString serverUuid)
 {
     ProgressManager *pm = ProgressManager::instance();
     pm->reInit();
@@ -760,8 +777,8 @@ void LocalDataInterface::sync(QJsonObject data)
 
     QString q = "DELETE FROM _Sync;";
     query( q );
-    q = "INSERT INTO _Sync ( lastSync) VALUES ( '%1' );";
-    query( q.arg( QDateTime::currentDateTimeUtc().toString("yyyy-MM-dd hh:mm:ss") ) );
+    q = "INSERT INTO _Sync ( lastSync, uuid ) VALUES ( '%1', '%2' );";
+    query( q.arg( QDateTime::currentDateTimeUtc().toString("yyyy-MM-dd hh:mm:ss"), serverUuid ) );
 
     pm->finish();
 }
@@ -953,7 +970,7 @@ void LocalDataInterface::quit()
     qDebug() << "LocalDataInterface: Everything's clean.";
 }
 
-LocalDataInterface::LocalDataInterface() :
+LocalDataInterface::LocalDataInterface():
     DuQFLoggerObject("Local Data Interface")
 {
     //Load local database
@@ -1006,7 +1023,6 @@ bool LocalDataInterface::openDB(QSqlDatabase db, const QString &dbFile)
         currentVersion = QVersionNumber::fromString( qry.value(0).toString() );
     }
 
-
     if (currentVersion < newVersion)
     {
         pm->setText(tr("Updating database scheme"));
@@ -1038,6 +1054,20 @@ bool LocalDataInterface::openDB(QSqlDatabase db, const QString &dbFile)
             qry.exec("UPDATE _Server SET port = 80 WHERE useSsl = 0;");
         }
 
+        if (currentVersion < QVersionNumber(0, 6, 0))
+        {
+            // Add the uuid entry to the _sync table
+            ok = qry.exec("ALTER TABLE _Sync ADD COLUMN \"uuid\" TEXT;");
+            if (!ok)
+            {
+                QString errorMessage = "Something went wrong when updating the database scheme to the new version.\nHere's some information:";
+                errorMessage += "\n> " + tr("Query:") + "\n" + qry.lastQuery();
+                errorMessage += "\n> " + tr("Database Error:") + "\n" + qry.lastError().databaseText();
+                errorMessage += "\n> " + tr("Driver Error:") + "\n" + qry.lastError().driverText();
+                LocalDataInterface::instance()->log(errorMessage, DuQFLog::Critical);
+            }
+        }
+
         if (ok)
         {
             // Remove previous version and update with ours

src/ramdatainterface/localdatainterface.h

@@ -58,6 +58,8 @@ class LocalDataInterface : public DuQFLoggerObject
     void updateUser(QString uuid, QString username, QString data, QString modified);
 
     ServerConfig serverConfig();
+    void setServerUuid(QString serverUuid);
+    QString serverUuid();
 
     QString ramsesPath();
     void setRamsesPath(QString path);
@@ -82,7 +84,7 @@ class LocalDataInterface : public DuQFLoggerObject
     const QHash<QString, QSet<QString> > &deletedUuids() const;
 
 public slots:
-    void sync(QJsonObject data);
+    void sync(QJsonObject data, QString serverUuid = "");
 
 signals:
     void dataReset();

src/ramdatainterface/ramserverinterface.cpp

@@ -333,7 +333,7 @@ QJsonArray RamServerInterface::downloadData()
 
 // PUBLIC SLOTS //
 
-void RamServerInterface::setOnline()
+void RamServerInterface::setOnline(QString serverUuid)
 {
     ProgressManager *pm = ProgressManager::instance();
 
@@ -371,16 +371,9 @@ void RamServerInterface::setOnline()
 
     QJsonObject repObj = parseData(reply);
 
-    bool repSuccess = repObj.value("success").toBool();
+    if (!checkPing(repObj, serverUuid)) return;
 
-    // If ping is not successful, set offline.
-    if (!repSuccess)
-    {
-        QString reason = tr("The server is unavailable.\nPlease check your network.\n\n(server ping failed)");
-        log(reason, DuQFLog::Warning);
-        setConnectionStatus(NetworkUtils::Offline, reason);
-        return;
-    }
+    m_localServerUuid = serverUuid;
 
     pm->setText(tr("Pong!"));
     pm->increment();
@@ -584,6 +577,10 @@ void RamServerInterface::dataReceived(QNetworkReply *reply)
     bool repSuccess = repObj.value("success").toBool();
     QString repMessage = repObj.value("message").toString();
     QJsonArray repLog = repObj.value("debug").toArray();
+    QString serverUuid = repObj.value("serverUuid").toString();
+
+    // Check server UUID
+    if (!checkServerUuid(repObj)) return;
 
     // Log
     for (int i = 0; i < repLog.count(); i++)
@@ -603,19 +600,11 @@ void RamServerInterface::dataReceived(QNetworkReply *reply)
     // Parse specific data
     if (repQuery == "ping")
     {
-        // If ping is not successful, set offline.
-        if (!repSuccess)
+        if (checkPing(repObj))
         {
-            QString reason = tr("The server is unavailable.\nPlease check your network.\n\n(server ping failed)");
-            log(reason, DuQFLog::Warning);
-            setConnectionStatus(NetworkUtils::Offline, reason);
-            return;
+            // If we're connecting, login!
+            if (m_status == NetworkUtils::Connecting) login();
         }
-
-        // get the server version
-        m_serverVersion = repObj.value("content").toObject().value("version").toString();
-        // If we're connecting, login!
-        if (m_status == NetworkUtils::Connecting) login();
     }
     else if (repQuery == "loggedout")
     {
@@ -634,7 +623,7 @@ void RamServerInterface::dataReceived(QNetworkReply *reply)
             return;
         }
 
-        emit syncReady(repObj.value("content").toObject());
+        emit syncReady(repObj.value("content").toObject(), serverUuid);
     }
     else if (repQuery == "setPassword")
     {
@@ -672,6 +661,48 @@ void RamServerInterface::nextRequest()
     postRequest( m_requestQueue.takeFirst() );
 }
 
+bool RamServerInterface::checkPing(QJsonObject repObj, QString serverUuid)
+{
+    bool repSuccess = repObj.value("success").toBool();
+
+    // If ping is not successful, set offline.
+    if (!repSuccess)
+    {
+        QString reason = tr("The server is unavailable.\nPlease check your network.\n\n(server ping failed)");
+        log(reason, DuQFLog::Warning);
+        setConnectionStatus(NetworkUtils::Offline, reason);
+        return false;
+    }
+
+    // Check the server UUID
+    if (serverUuid != "") m_localServerUuid = serverUuid;
+    if (!checkServerUuid(repObj)) return false;
+
+    // get the server version
+    m_serverVersion = repObj.value("content").toObject().value("version").toString();
+
+    emit pong(repObj.value("serverUuid").toString());
+    return true;
+}
+
+bool RamServerInterface::checkServerUuid(QJsonObject repObj)
+{
+    QString distantUuid = repObj.value("serverUuid").toString();
+    if (m_localServerUuid != "" && distantUuid != "" && m_localServerUuid != distantUuid)
+    {
+        QString reason = tr("This server is not in sync with this local database.\n\n"
+                            "This can happen if you try to connect to a new server from an existing database,\n"
+                            "Of if the server has been updated, or its configuration changed.\n\n"
+                            "Create a new database to connect to this server ( %1 ).").arg(
+                                serverAddress()
+                            );
+        log(reason, DuQFLog::Critical);
+        setConnectionStatus(NetworkUtils::Offline, tr("This server is not in sync with this local database."));
+        return false;
+    }
+    return true;
+}
+
 void RamServerInterface::queueRequest(QString query, QJsonObject body)
 {
     Request r = buildRequest(query, body);

src/ramdatainterface/ramserverinterface.h

@@ -73,7 +73,7 @@ public slots:
      * @brief setOnline posts a ping, and set the status to "Connecting"
      * Status will be changed to "Connected" if we get a valid pong
      */
-    void setOnline();
+    void setOnline(QString serverUuid = "");
     void setOffline();
     void login();
     QString doLogin(QString username, QString password, bool saveUsername = false, bool savePassword = false);
@@ -82,9 +82,10 @@ public slots:
 signals:
     void sslChanged(bool);
     void connectionStatusChanged(NetworkUtils::NetworkStatus, QString);
-    void syncReady(QJsonObject);
+    void syncReady(QJsonObject data, QString serverUuid);
     void newData(QJsonObject);
     void userChanged(QString uuid, QString username, QString userdata, QString modified);
+    void pong(QString serverUuid);
 
 protected:
     static RamServerInterface *_instance;
@@ -119,6 +120,9 @@ private slots:
      */
     void nextRequest();
 
+    bool checkPing(QJsonObject repObj, QString serverUuid = "");
+    bool checkServerUuid(QJsonObject repObj);
+
 private:
 
     // METHODS //
@@ -211,6 +215,8 @@ private slots:
      */
     int m_timeout = 3000;
 
+    QString m_localServerUuid = "";
+
     /**
      * @brief Online / Offline status
      */