raise error for invalid input

songmeo · songmeo · commit a13d0a1e39d6 · 2025-07-20T00:24:26.000+03:00
diff --git a/pycyphal/transport/can/media/pythoncan/_pythoncan.py b/pycyphal/transport/can/media/pythoncan/_pythoncan.py
@@ -489,6 +489,8 @@ def _construct_pcan(parameters: _InterfaceParameters) -> can.ThreadSafeBus:
             ),
         )
     if isinstance(parameters, _FDInterfaceParameters):
+        if parameters.bitrate[0] == 0 or parameters.bitrate[1] == 0:
+            raise InvalidMediaConfigurationError("Bitrate must be non-zero")
         # These magic numbers come from the settings of PCAN adapter.
         # They don't allow any direct baudrate settings, you have to set all lengths and value of the main frequency.
         # Bit lengths below are very universal and can be applied for almost every popular baudrate.

Original file line number	Diff line number	Diff line change
`@@ -489,6 +489,8 @@ def _construct_pcan(parameters: _InterfaceParameters) -> can.ThreadSafeBus:`
`489`	`489`	`),`
`490`	`490`	`)`
`491`	`491`	`if isinstance(parameters, _FDInterfaceParameters):`
	`492`	`+ if parameters.bitrate[0] == 0 or parameters.bitrate[1] == 0:`
	`493`	`+ raise InvalidMediaConfigurationError("Bitrate must be non-zero")`
`492`	`494`	`# These magic numbers come from the settings of PCAN adapter.`
`493`	`495`	`# They don't allow any direct baudrate settings, you have to set all lengths and value of the main frequency.`
`494`	`496`	`# Bit lengths below are very universal and can be applied for almost every popular baudrate.`