[MIG] account_lock_date_update to v18

alexis-via · alexis-via · commit b4af7e63cc9b · 2024-12-31T00:46:28.000+01:00
diff --git a/account_lock_date_update/__manifest__.py b/account_lock_date_update/__manifest__.py
@@ -6,7 +6,7 @@
     "summary": """
         Allow an Account adviser to update locking date without having
         access to all technical settings""",
-    "version": "17.0.1.0.1",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "ACSONE SA/NV, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/account-financial-tools",
diff --git a/account_lock_date_update/readme/DESCRIPTION.md b/account_lock_date_update/readme/DESCRIPTION.md
@@ -1,2 +1 @@
-Allow an Account adviser to update locking dates without having access
-to all technical settings.
+Allow an Account adviser to update accounting lock dates.
diff --git a/account_lock_date_update/readme/USAGE.md b/account_lock_date_update/readme/USAGE.md
@@ -1,4 +1,4 @@
 To use this module, you need to be a Billing Administrator and go to:
 
-- Invoicing -\> Accounting -\> Actions -\> Update accounting lock dates
+- Invoicing -\> Accounting -\> Lock Dates
 - Change values and click on **Update** button
diff --git a/account_lock_date_update/security/ir.model.access.csv b/account_lock_date_update/security/ir.model.access.csv
@@ -1,2 +1,3 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_account_update_lock_date_full,Full access on account.update.lock_date,model_account_update_lock_date,account.group_account_manager,1,1,1,1
+access_account_update_lock_date_readonly,Readonly access on account.update.lock_date to auditor,model_account_update_lock_date,account.group_account_readonly,1,0,0,0
diff --git a/account_lock_date_update/tests/test_account_lock_date_update.py b/account_lock_date_update/tests/test_account_lock_date_update.py
@@ -1,7 +1,7 @@
 # Copyright 2017 ACSONE SA/NV
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import fields
+from odoo import Command, fields
 from odoo.exceptions import AccessError
 from odoo.tests.common import TransactionCase
 
@@ -26,33 +26,41 @@ def setUpClass(cls):
         cls.adviser_group = cls.env.ref("account.group_account_manager")
 
     def test_01_update_without_access(self):
-        self.demo_user.write({"groups_id": [(3, self.adviser_group.id)]})
+        self.demo_user.write({"groups_id": [Command.unlink(self.adviser_group.id)]})
         with self.assertRaises(AccessError):
             self.env["account.update.lock_date"].with_user(self.demo_user.id).create(
                 {"company_id": self.company.id}
             )
 
     def test_02_update_with_access(self):
-        self.demo_user.write({"groups_id": [(4, self.adviser_group.id)]})
+        self.demo_user.write({"groups_id": [Command.link(self.adviser_group.id)]})
         wizard = (
             self.env["account.update.lock_date"]
             .with_user(self.demo_user.id)
             .create({"company_id": self.company.id})
         )
         wizard.write(
             {
-                "period_lock_date": "2000-02-01",
-                "fiscalyear_lock_date": "2000-01-01",
-                "tax_lock_date": "2000-01-01",
+                "sale_lock_date": "2000-05-01",
+                "purchase_lock_date": "2000-04-01",
+                "tax_lock_date": "2000-03-01",
+                "fiscalyear_lock_date": "2000-02-01",
+                "hard_lock_date": "2000-01-01",
             }
         )
         wizard.with_user(self.demo_user.id).execute()
         self.assertEqual(
-            fields.Date.to_string(self.company.period_lock_date), "2000-02-01"
+            fields.Date.to_string(self.company.sale_lock_date), "2000-05-01"
         )
         self.assertEqual(
-            fields.Date.to_string(self.company.fiscalyear_lock_date), "2000-01-01"
+            fields.Date.to_string(self.company.purchase_lock_date), "2000-04-01"
         )
         self.assertEqual(
-            fields.Date.to_string(self.company.tax_lock_date), "2000-01-01"
+            fields.Date.to_string(self.company.tax_lock_date), "2000-03-01"
+        )
+        self.assertEqual(
+            fields.Date.to_string(self.company.fiscalyear_lock_date), "2000-02-01"
+        )
+        self.assertEqual(
+            fields.Date.to_string(self.company.hard_lock_date), "2000-01-01"
         )
diff --git a/account_lock_date_update/wizards/account_update_lock_date.py b/account_lock_date_update/wizards/account_update_lock_date.py
@@ -3,42 +3,47 @@
 
 from odoo import _, api, fields, models
 from odoo.exceptions import UserError
+from odoo.tools.misc import format_date
+
+from odoo.addons.account.models.company import LOCK_DATE_FIELDS
 
 
 class AccountUpdateLockDate(models.TransientModel):
     _name = "account.update.lock_date"
     _description = "Wizard to Update Accounting Lock Dates"
 
     company_id = fields.Many2one(comodel_name="res.company", required=True)
-    period_lock_date = fields.Date(
-        string="Lock Date for Non-Advisers",
-        help="Only users with the 'Adviser' role can edit accounts prior to "
-        "and inclusive of this date. Use it for period locking inside an "
-        "open fiscal year, for example.",
-    )
     fiscalyear_lock_date = fields.Date(
-        string="Lock Date for All Users",
-        help="No users, including Advisers, can edit accounts prior to and "
-        "inclusive of this date. Use it for fiscal year locking for "
-        "example.",
+        string="Global Lock Date",
+        help="Impossible to edit/create journal entries prior to and "
+        "inclusive of this date. Subject to exceptions.",
     )
     tax_lock_date = fields.Date(
-        help="No users can edit journal entries related to a tax prior and "
-        "inclusive of this date.",
+        string="Tax Return Lock Date",
+        help="Impossible to edit/create journal entries related to a tax prior and "
+        "inclusive of this date. Subject to exceptions.",
+    )
+    sale_lock_date = fields.Date(
+        help="Impossible to edit/create sale journal entries prior to and "
+        "inclusive of this date. Subject to exceptions.",
+    )
+    purchase_lock_date = fields.Date(
+        help="Impossible to edit/create purchase journal entries prior to and "
+        "inclusive of this date. Subject to exceptions.",
+    )
+    hard_lock_date = fields.Date(
+        help="Impossible to edit/create journal entries prior to and "
+        "inclusive of this date. This lock date is irreversible and "
+        "does not allow any exception.",
     )
 
     @api.model
     def default_get(self, field_list):
         res = super().default_get(field_list)
         company = self.env.company
-        res.update(
-            {
-                "company_id": company.id,
-                "period_lock_date": company.period_lock_date,
-                "fiscalyear_lock_date": company.fiscalyear_lock_date,
-                "tax_lock_date": company.tax_lock_date,
-            }
-        )
+        for lock_field in LOCK_DATE_FIELDS:
+            res[lock_field] = company[lock_field]
+        res["company_id"] = company.id
         return res
 
     def _check_execute_allowed(self):
@@ -50,10 +55,28 @@ def _check_execute_allowed(self):
     def execute(self):
         self.ensure_one()
         self._check_execute_allowed()
-        self.company_id.sudo().write(
-            {
-                "period_lock_date": self.period_lock_date,
-                "fiscalyear_lock_date": self.fiscalyear_lock_date,
-                "tax_lock_date": self.tax_lock_date,
-            }
+        today = fields.Date.context_today(self)
+        fields_sr = (
+            self.env["ir.model.fields"]
+            .sudo()
+            .search_read(
+                [("model", "=", self._name), ("name", "in", LOCK_DATE_FIELDS)],
+                ["field_description", "name"],
+            )
+        )
+        field2string = dict(
+            (field["name"], field["field_description"]) for field in fields_sr
         )
+        vals = {}
+        for lock_field in LOCK_DATE_FIELDS:
+            if self[lock_field] and self[lock_field] > today:
+                raise UserError(
+                    _(
+                        "You tried to set %(field)s to %(date)s, "
+                        "but it is in the future.",
+                        field=field2string[lock_field],
+                        date=format_date(self.env, self[lock_field]),
+                    )
+                )
+            vals[lock_field] = self[lock_field]
+        self.company_id.sudo().write(vals)
diff --git a/account_lock_date_update/wizards/account_update_lock_date.xml b/account_lock_date_update/wizards/account_update_lock_date.xml
@@ -10,40 +10,45 @@
         <field name="arch" type="xml">
             <form>
                 <sheet>
-                    <group id="main">
+                    <group id="soft_lock_dates" string="Reversible Lock Dates">
                         <field name="company_id" invisible="1" />
-                        <field name="tax_lock_date" options="{'warn_future': true}" />
+                        <field name="sale_lock_date" options="{'warn_future': true}" />
                         <field
-                            name="period_lock_date"
+                            name="purchase_lock_date"
                             options="{'warn_future': true}"
                         />
+                        <field name="tax_lock_date" options="{'warn_future': true}" />
                         <field
                             name="fiscalyear_lock_date"
                             options="{'warn_future': true}"
                         />
                     </group>
+                    <group id="hard_lock_dates" string="Irreversible Lock Date">
+                        <field name="hard_lock_date" options="{'warn_future': true}" />
+                    </group>
                 </sheet>
                 <footer>
                     <button
                         string="Update"
                         name="execute"
                         type="object"
                         class="btn-primary"
+                        groups="account.group_account_manager"
                     />
                     <button string="Cancel" class="btn-default" special="cancel" />
                 </footer>
             </form>
         </field>
     </record>
     <record id="account_update_lock_date_act_window" model="ir.actions.act_window">
-        <field name="name">Update Lock Dates</field>
+        <field name="name">Lock Dates</field>
         <field name="res_model">account.update.lock_date</field>
         <field name="view_mode">form</field>
         <field name="target">new</field>
     </record>
     <record id="account_update_lock_date_menu" model="ir.ui.menu">
-        <field name="name">Update Lock Dates</field>
-        <field name="parent_id" ref="account.menu_finance_entries_actions" />
+        <field name="name">Lock Dates</field>
+        <field name="parent_id" ref="account.menu_finance_entries" />
         <field name="action" ref="account_update_lock_date_act_window" />
         <field name="sequence" eval="70" />
     </record>

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`		`-Allow an Account adviser to update locking dates without having access`
`2`		`-to all technical settings.`
	`1`	`+Allow an Account adviser to update accounting lock dates.`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink`
`2`	`2`	`access_account_update_lock_date_full,Full access on account.update.lock_date,model_account_update_lock_date,account.group_account_manager,1,1,1,1`
	`3`	`+access_account_update_lock_date_readonly,Readonly access on account.update.lock_date to auditor,model_account_update_lock_date,account.group_account_readonly,1,0,0,0`