(chore): perform lint of entire codebase

Author: markharding

.gitlab-ci.yml

@@ -35,6 +35,12 @@ test:
   script:
     - bin/phpspec run
 
+lint:
+  stage: test
+  image: minds/php-tests:latest
+  script:
+    - bin/php-cs-fixer fix --allow-risky=yes --verbose --dry-run
+
 prepare:fpm:
   stage: prepare
   image: minds/ci:latest

.php_cs

@@ -5,5 +5,10 @@ $finder = PhpCsFixer\Finder::create()
     ->in(__DIR__);
 
 return PhpCsFixer\Config::create()
-      ->fixers(['psr2', 'strict_param', 'short_array_syntax', 'no_blank_lines_after_class_opening'])
-      ->finder($finder);
+    ->setRules([
+        '@PSR2' => true,
+        'strict_param' => true,
+        'array_syntax' => ['syntax' => 'short'],
+        'no_blank_lines_after_class_opening' => true,
+    ])
+    ->setFinder($finder);

Api/Factory.php

@@ -50,7 +50,7 @@ public static function build($segments, $request, $response)
                     if (!$handler instanceof Interfaces\ApiIgnorePam) {
                         self::pamCheck($request, $response);
                     }
-                    $pages = array_splice($segments, $loop) ?: array();
+                    $pages = array_splice($segments, $loop) ?: [];
                     return $handler->$method($pages);
                 }
             }
@@ -65,7 +65,7 @@ public static function build($segments, $request, $response)
                 if (!$handler instanceof Interfaces\ApiIgnorePam) {
                     self::pamCheck($request, $response);
                 }
-                $pages = array_splice($segments, $loop) ?: array();
+                $pages = array_splice($segments, $loop) ?: [];
                 return $handler->$method($pages);
             }
             --$loop;
@@ -78,7 +78,7 @@ public static function build($segments, $request, $response)
      */
     public static function pamCheck($request, $response)
     {
-        if ( $request->getAttribute('oauth_user_id') 
+        if ($request->getAttribute('oauth_user_id')
             || Security\XSRF::validateRequest()
         ) {
             return true;
@@ -89,7 +89,7 @@ public static function pamCheck($request, $response)
             header("Access-Control-Allow-Origin: *");
             header('HTTP/1.1 401 Unauthorized', true, 401);
             echo json_encode([
-                'error' => 'Sorry, you are not authenticated', 
+                'error' => 'Sorry, you are not authenticated',
                 'code' => 401,
                 'loggedin' => false
                 ]);
@@ -111,7 +111,7 @@ private static function adminCheck()
             header('Content-type: application/json');
             header("Access-Control-Allow-Origin: *");
             header('HTTP/1.1 401 Unauthorized', true, 401);
-            echo json_encode(array('error'=>'You are not an admin', 'code'=>401));
+            echo json_encode(['error'=>'You are not an admin', 'code'=>401]);
             exit;
         }
     }
@@ -122,7 +122,7 @@ private static function adminCheck()
      */
     public static function isLoggedIn()
     {
-        if(Session::isLoggedIn()){
+        if (Session::isLoggedIn()) {
             return true;
         } else {
             ob_end_clean();
@@ -143,11 +143,11 @@ public static function isLoggedIn()
      * Builds an API response
      * @param array $data
      */
-    public static function response($data = array())
+    public static function response($data = [])
     {
-        $data = array_merge(array(
+        $data = array_merge([
             'status' => 'success', //should success be assumed?
-        ), $data);
+        ], $data);
 
         ob_end_clean();
 
@@ -162,9 +162,9 @@ public static function response($data = array())
      * @return array - an array of the entities
      * @deprecated
      */
-    public static function exportable($entities, $exceptions = array(), $exportContext = false)
+    public static function exportable($entities, $exceptions = [], $exportContext = false)
     {
-        if(!$entities){
+        if (!$entities) {
             return [];
         }
         foreach ($entities as $k => $entity) {

Api/Routes.php

@@ -6,7 +6,7 @@
  */
 class Routes
 {
-    public static $routes = array();
+    public static $routes = [];
 
     /**
      * Adds a custom API route resolution

Cli/Factory.php

@@ -61,11 +61,11 @@ public static function build($segments)
     public static function toCamelNsp($namespace)
     {
         $namespace = explode('\\', $namespace);
-        $replacer = function($matches) {
+        $replacer = function ($matches) {
             return strtoupper($matches[1]);
         };
 
-        array_walk($namespace, function(&$segment) use ($replacer) {
+        array_walk($namespace, function (&$segment) use ($replacer) {
             $segment = ucfirst(preg_replace_callback('/_([a-z])/', $replacer, $segment));
         });
 

Cli/Routes.php

@@ -6,7 +6,7 @@
  */
 class Routes
 {
-    public static $routes = array();
+    public static $routes = [];
 
     /**
      * Adds a custom CLI route resolution

Common/Cookie.php

@@ -8,16 +8,15 @@
 /**
  * Class Cookie
  * @method Cookie setName(string $name)
- * @method Cookie setValue(string $value) 
+ * @method Cookie setValue(string $value)
  * @method Cookie setExpire(int $value)
  * @method Cookie setPath(string $path)
- * @method Cookie setDomain(string $domain) 
+ * @method Cookie setDomain(string $domain)
  * @method Cookie setSecure(bool $secure)
  * @method Cookie setHttpOnly(bool $httpOnly)
  */
 class Cookie
 {
-
     use MagicAttributes;
 
     /** @var CONFIG $config */
@@ -71,5 +70,4 @@ public function create()
         setcookie($this->name, $this->value, $this->expire, $this->path, $this->domain, $this->secure, $this->httpOnly);
         $_COOKIE[$this->name] = $this->value; //set the global cookie
     }
-
 }

Components/Controller.php

@@ -9,7 +9,8 @@
  * @todo Create a BaseController class (to be used on Api, Cli, etc) with core DI operations.
  * @todo Ensure this class is used EVERYWHERE on Minds\Controllers\api
  */
-class Controller {
+class Controller
+{
     protected $di;
     protected $config;
 

Controllers/Cli/AbuseGuard.php

@@ -34,7 +34,6 @@ public function run()
         $interval = $this->getOpt('interval') ?: 5;
 
         while (true) {
-            
             $guard->setPeriod(
                 time() - (60 * 60 * 10),
                 time()
@@ -50,7 +49,6 @@ public function run()
 
             sleep($interval);
         }
-  
     }
 
     public function sync_single()

Controllers/Cli/Analytics.php

@@ -122,7 +122,7 @@ public function sync_graphs()
         foreach ($aggregates as $aggregate) {
             $this->out("Syncing {$aggregate}");
 
-            try { 
+            try {
                 $manager->sync([
                     'aggregate' => $aggregate,
                     'all' => true,
@@ -132,7 +132,7 @@ public function sync_graphs()
         }
 
         $this->out('Completed caching site metrics');
-   }
+    }
 
     public function syncViews()
     {
@@ -158,5 +158,4 @@ public function syncViews()
         }
         $this->out('Done');
     }
-
 }

Controllers/Cli/Blockchain.php

@@ -46,7 +46,7 @@ public function listen()
         if (function_exists('pcntl_signal')) {
             // Intercept Ctrl+C
 
-            pcntl_signal(SIGINT, function() {
+            pcntl_signal(SIGINT, function () {
                 $this->filterCleanup();
                 exit;
             });
@@ -106,7 +106,6 @@ public function listen()
                         }
                     }
                 }
-
             }
 
             usleep(500 * 1000); // 500ms
@@ -143,24 +142,24 @@ public function setRate()
     {
         error_reporting(E_ALL);
         ini_set('display_errors', 1);
-while (true) {
-        $ethereum = Di::_()->get('Blockchain\Services\Ethereum');
-        $config = Di::_()->get('Config');
-        $ethRate = new EthRate;
-        $ethPrice = new EthPrice;
-        $ethPrice->setFrom(strtotime('24 hours ago'))
+        while (true) {
+            $ethereum = Di::_()->get('Blockchain\Services\Ethereum');
+            $config = Di::_()->get('Config');
+            $ethRate = new EthRate;
+            $ethPrice = new EthPrice;
+            $ethPrice->setFrom(strtotime('24 hours ago'))
             ->setTo(time())
             ->get();
 
-        $eth = round($ethPrice->getNearestPrice(strtotime('1 minute ago')));
-        $usd = 1.25;
+            $eth = round($ethPrice->getNearestPrice(strtotime('1 minute ago')));
+            $usd = 1.25;
 
-        $rate = round($eth/$usd);
-        if ($rate % 2 !== 0) {
-           $rate++;
-        }
+            $rate = round($eth/$usd);
+            if ($rate % 2 !== 0) {
+                $rate++;
+            }
 
-        $txHash = $ethereum->sendRawTransaction($config->blockchain['contracts']['token_sale_event']['rate_pkey'], [
+            $txHash = $ethereum->sendRawTransaction($config->blockchain['contracts']['token_sale_event']['rate_pkey'], [
             'from' => $config->blockchain['contracts']['token_sale_event']['rate_address'],
             'to' => $config->blockchain['contracts']['token_sale_event']['contract_address'],
             'gasLimit' => BigNumber::_(200000)->toHex(true),
@@ -170,31 +169,31 @@ public function setRate()
             ])
         ]);
 
-        // Wait until mined before updating our backend
+            // Wait until mined before updating our backend
 
-        while (true) {
-            sleep(1);
-            $receipt = $ethereum->request('eth_getTransactionReceipt', [ $txHash ]);
-            echo "\n Waiting for $txHash";
-            if ($receipt && $receipt['status']) {
-                if ($receipt['status'] !== '0x1') {
-                    echo "\n$txHash failed";
+            while (true) {
+                sleep(1);
+                $receipt = $ethereum->request('eth_getTransactionReceipt', [ $txHash ]);
+                echo "\n Waiting for $txHash";
+                if ($receipt && $receipt['status']) {
+                    if ($receipt['status'] !== '0x1') {
+                        echo "\n$txHash failed";
+                    }
+                    break;
                 }
-                break;
             }
-        }
 
-        $ethRate->set($rate);
-        echo "\n Completed: new rate is $rate: $txHash";
-        echo "\n Now sleeping for one hour";
-        sleep(3600);
-}
+            $ethRate->set($rate);
+            echo "\n Completed: new rate is $rate: $txHash";
+            echo "\n Now sleeping for one hour";
+            sleep(3600);
+        }
     }
 
     public function balance()
     {
         error_reporting(E_ALL);
-                ini_set('display_errors', 1);
+        ini_set('display_errors', 1);
 
         $username = $this->getOpt('username');
         $user = new \Minds\Entities\User($username);

Controllers/Cli/Contributions.php

@@ -14,7 +14,6 @@
 
 class Contributions extends Cli\Controller implements Interfaces\CliControllerInterface
 {
-
     private $start;
     private $elasticsearch;
 
@@ -49,7 +48,7 @@ public function sync()
 
         $this->out("Getting rewards for all users");
 
-        $total = 0; 
+        $total = 0;
         $i = 0;
         foreach ($users as $guid) {
             $i++;
@@ -120,7 +119,7 @@ public function syncCheckins()
                 $hash = $user->getPhoneNumberHash();
 
                 if (isset($hashes[$hash])) { //don't allow multiple phones to claim checkin
-                    $duplicates++; 
+                    $duplicates++;
                     continue;
                 }
                 $hashes[$hash] = true;
@@ -143,7 +142,7 @@ public function syncCheckins()
                     ->setUser($checkin['user'])
                     ->issueCheckins($checkin['amount']);
         }
-    } 
+    }
 
     public function test()
     {
@@ -162,7 +161,7 @@ public function test()
             ->setDryRun(true);
 
         if ($user->guid) {
-             $manager->setUser($user);
+            $manager->setUser($user);
         }
         $results = $manager->sync();
 
@@ -171,9 +170,8 @@ public function test()
         foreach ($results as $result) {
             $totals += $result->getAmount();
             $totals_by_type[$result->getMetric()] += $result->getAmount();
-        } 
+        }
         var_dump($totals);
         var_dump($totals_by_type);
     }
-
 }

Controllers/Cli/CreateFoundersIndex.php

@@ -12,7 +12,6 @@
 
 class CreateFoundersIndex extends Cli\Controller implements Interfaces\CliControllerInterface
 {
-
     public function help($command = null)
     {
         $this->out('TBD');
@@ -21,7 +20,7 @@ public function help($command = null)
     public function exec()
     {
         error_reporting(E_ALL);
-        ini_set('display_errors', 1);        
+        ini_set('display_errors', 1);
         $db = Di::_()->get('Database\Cassandra\Cql');
         $entities_by_time = new Core\Data\Call('entities_by_time');
 
@@ -34,9 +33,8 @@ public function exec()
             echo "\n[$i]:$user->guid";
             if ($user->founder) {
                 echo "\n[$i]:$user->guid indexed";
-                $entities_by_time->insert('user:founders',  [ (string) $user->guid => (string) $user->guid ]);
+                $entities_by_time->insert('user:founders', [ (string) $user->guid => (string) $user->guid ]);
             }
         }
-
     }
 }