src/DatabaseLibrary/query.py

@@ -346,7 +346,6 @@ def execute_sql_script(
                             # check if the semicolon is a part of the value (quoted string)
                             quotes += sqlFragment.count("'")
                             quotes -= sqlFragment.count("\\'")
-                            quotes -= sqlFragment.count("''")
                             inside_quoted_string = quotes % 2 != 0
                             if inside_quoted_string:
                                 sqlFragment += ";"  # restore the semicolon
@@ -827,7 +826,11 @@ def _log_query_results(self, col_names, result_rows, log_head: Optional[int] = N
             msg += f"<tr{row_style}>"
             msg += f'<th scope="row" style="color:{row_index_text_color}; background-color: {row_index_background_color};{cell_border_and_align}">{i}</th>'
             for cell in row:
-                msg += f'<td style="{cell_border_and_align}">{cell}</td>'
+                try:
+                    cell_string = str(cell)
+                except TypeError as e:
+                    cell_string = f"Unable printing the value: {e}"
+                msg += f'<td style="{cell_border_and_align}">{cell_string}</td>'
             msg += "</tr>"
         msg += "</table>"
         if table_truncated:

src/DatabaseLibrary/version.py

@@ -1 +1 @@
-VERSION = "2.1.3"
+VERSION = "2.1.4"

test/resources/script_file_tests/semicolons_and_quotes_in_values.sql

@@ -1 +1,2 @@
-INSERT INTO person VALUES(5, 'Miles', 'O''Brian');
+INSERT INTO person VALUES(5, 'Miles', 'O''Brian');
+INSERT INTO person VALUES(6, 'Keiko', 'O''Brian');

test/tests/common_tests/connection_params.robot

@@ -19,7 +19,7 @@ Test Teardown       Disconnect From Database
 ...    invalid custom param=TypeError: connect() got an unexpected keyword argument 'blah'
 &{Errors pymysql}
 ...    missing basic params=OperationalError: (1045, "Access denied*
-...    invalid custom param=TypeError: Connection.__init__() got an unexpected keyword argument 'blah'
+...    invalid custom param=REGEXP: TypeError.*__init__.*got an unexpected keyword argument 'blah'
 &{Errors pyodbc}
 ...    missing basic params=REGEXP: InterfaceError.*Data source name not found and no default driver specified.*
 

test/tests/common_tests/script_files.robot

@@ -29,10 +29,11 @@ Semicolons In Values
 Semicolons And Quotes In Values
     Run SQL Script File    semicolons_and_quotes_in_values
     ${sql}=    Catenate    select * from person
-    ...    where id=5
+    ...    where LAST_NAME='O''Brian'
     ${results}=    Query    ${sql}
-    Length Should Be    ${results}    1
+    Length Should Be    ${results}    2
     Should Be Equal As Strings    ${results}[0]    (5, 'Miles', "O'Brian")
+    Should Be Equal As Strings    ${results}[1]    (6, 'Keiko', "O'Brian")
 
 
 *** Keywords ***

test/tests/custom_db_tests/oracle_blob.robot

@@ -0,0 +1,29 @@
+*** Settings ***
+Documentation       Tests for querying a table with BLOB data type.
+...                 The data type naming is DB specific, these tests are designed for Oracle DB only.
+
+Resource            ../../resources/common.resource
+
+Suite Setup         Connect To DB
+Suite Teardown      Disconnect From Database
+Test Setup          Execute Sql String
+...                     CREATE TABLE blob_table (id integer not null unique, data blob)
+Test Teardown       Execute Sql String    DROP TABLE blob_table
+
+
+*** Variables ***
+${DB_MODULE}            oracledb
+${DB_HOST}              127.0.0.1
+${DB_PORT}              1521
+${DB_PASS}              pass
+${DB_USER}              db_user
+${DB_NAME}              db
+${ORACLE_LIB_DIR}       ${EMPTY}
+
+
+*** Test Cases ***
+Blob Data Type - Logging Results Causes No Error
+    [Documentation]    See https://github.com/MarketSquare/Robotframework-Database-Library/issues/244
+    ${binary_data}=    Evaluate    b'abc'
+    Execute Sql String    INSERT INTO blob_table VALUES(1, '${binary_data}')
+    ${result}=    Query    SELECT data FROM blob_table WHERE id=1