apply clang-tidy modernize-use-override

Summary: Use clang-tidy to mechanically add missing `override` and remove redundant `virtual`.

Reviewed By: igorsugak

Differential Revision: D5211868

fbshipit-source-id: 6a85f7c4a543a4c9345ec5b0681a8853707343dc

Author: vgao1996

Sender.h

@@ -45,7 +45,7 @@ class Sender : public WdtBase {
    * If the transfer has not finished, then it is aborted. finish() is called to
    * wait for threads to end.
    */
-  virtual ~Sender();
+  ~Sender() override;
 
   /**
    * Joins on the threads spawned by start. This has to
@@ -134,7 +134,7 @@ class Sender : public WdtBase {
     explicit QueueAbortChecker(Sender *sender) : sender_(sender) {
     }
 
-    bool shouldAbort() const {
+    bool shouldAbort() const override {
       return (sender_->getTransferStatus() == FINISHED);
     }
 

util/ClientSocket.h

@@ -24,7 +24,7 @@ class ClientSocket : public WdtSocket {
   /// @return   peer-ip of the connected socket
   const std::string &getPeerIp() const;
   /// shutdown() is now on WdtSocket as shutdownWrites()
-  virtual ~ClientSocket();
+  ~ClientSocket() override;
 
  protected:
   /// sets the send buffer size for this socket

util/DirectorySourceQueue.h

@@ -85,14 +85,14 @@ class DirectorySourceQueue : public SourceQueue {
    *
    * @return next FileByteSource to consume or nullptr when finished
    */
-  virtual std::unique_ptr<ByteSource> getNextSource(ThreadCtx *callerThreadCtx,
-                                                    ErrorCode &status) override;
+  std::unique_ptr<ByteSource> getNextSource(ThreadCtx *callerThreadCtx,
+                                            ErrorCode &status) override;
 
   /// @return         total number of files processed/enqueued
-  virtual int64_t getCount() const override;
+  int64_t getCount() const override;
 
   /// @return         total size of files processed/enqueued
-  virtual int64_t getTotalSize() const override;
+  int64_t getTotalSize() const override;
 
   /// @return         total number of blocks and status of the transfer
   std::pair<int64_t, ErrorCode> getNumBlocksAndStatus() const;
@@ -210,7 +210,7 @@ class DirectorySourceQueue : public SourceQueue {
   /// @return   number of bytes previously sent
   int64_t getPreviouslySentBytes() const;
 
-  virtual ~DirectorySourceQueue();
+  ~DirectorySourceQueue() override;
 
   /// @return   discovered files metadata
   std::vector<SourceMetaData *> &getDiscoveredFilesMetaData();

util/FileWriter.h

@@ -28,23 +28,23 @@ class FileWriter : public Writer {
         fileCreator_(fileCreator) {
   }
 
-  virtual ~FileWriter() {
+  ~FileWriter() override {
     close();
   }
 
   /// @see Writer.h
-  virtual ErrorCode open() override;
+  ErrorCode open() override;
 
   /// @see Writer.h
-  virtual ErrorCode write(char *buf, int64_t size) override;
+  ErrorCode write(char *buf, int64_t size) override;
 
   /// @see Writer.h
-  virtual int64_t getTotalWritten() override {
+  int64_t getTotalWritten() override {
     return totalWritten_;
   }
 
   /// @see Writer.h
-  virtual void close() override;
+  void close() override;
 
  private:
   /**

util/ServerSocket.h

@@ -25,7 +25,7 @@ class ServerSocket : public WdtSocket {
   ServerSocket(ThreadCtx &threadCtx, int port, int backlog,
                const EncryptionParams &encryptionParams,
                int64_t ivChangeInterval, Func &&tagVerificationSuccessCallback);
-  virtual ~ServerSocket();
+  ~ServerSocket() override;
   /// Sets up listening socket (first wildcard type (ipv4 or ipv6 depending
   /// on flag)).
   ErrorCode listen();