tests for AddNotes.py

[Tian99]

Similar to test_multiRA_insertions.py

[suv27]

So I can understand this more, do you want unit test for the MultiRA.py python file? If this is correct, I would like to work on it and can you please assign it to me?

[WillForan]

@Physsix27 Thanks for the interest! The issue is for AddNotes.py.

While the repo is open source and any help is welcome, LNCDschedule's scope is rather specific: schedule and record visits for the laboratory of neurocognative development. The integrations are limited to our api keys (qualtrics, gcal) or within our firewall (psql) and the schema is specific to the particular needs of the lab. So, not too useful to the world at large.

I feel like we'd be taking a generous resource from projects that have something more to offer the open source community. But, if that doesn't moderate your enthusiasm, I'll happily assign the issue to you!

[suv27]

That shouldn't be a problem, yes please assign it to me.

[suv27]

Hey @WillForan, would it be ok to create tests/test_AddNotes.py and write my tests in that file?
Just would like to know if you would like that structure.

[WillForan]

There is some effort to separate db and ui tests into their own directories. so tests/ui/test_AddNotes.py might be the most appropriate place.

[suv27]

Can you please walk me through how you run your tests and how do you install all the requirements needed?

[WillForan]

Good question! I made it issue #32. tests/readme.md now has a bit more info.
Essentially you need all the dependencies + pytest fixtures. pdbpp also make debugging tests nicer.

python3 -m pip install --user PyQt5 pyesql psycopg2 'git+https://github.com/LabNeuroCogDevel/LNCDcal.py#egg=9592386' pyOpenSSL pytest-qt pytest-pgsql sqlalchemy pdbpp

and then run pytest on the test file

python3 -m pytest --pdb tests/ui/test_AddNotes.py

As an aside, I noticed (at least for me on archlinux) I need to install the actual database software postgresql for the python package pytest-pgsql's initdb to run successfully

[WillForan]

whoa! there are more tests (and they're better organized) than what we have in this repo.

My instructions above failed to mention pytest should be run from the root directory of this repo ($PWD ends with LNCDschedule/). Looks like you might be running from the home directory?

[suv27]

Hey, I am so sorry lol. I missed two projects that I am currently working on, that picture does not reference your repo.
Now I tried again in the correct repo, sorry again, and this is the error that I am facing.

[WillForan]

Hmm. One error looks like LNCDcal depend is missing.
The local lncdSql can fail to load for similar depend issues. That error is thrown a lot. Maybe try python -c 'import lncdSql' to see why it's unhappy

[suv27]

Alright, so I will be making a PR to fix and make everything easier to set up, as I found the problem.
This PR will contain a new requirements.txt and a modification to the Makefile and it looks like there is a need for cleaning the project too since it has a lot of lint error and that is one of the targets in you Makefile . You can make that an issue to clean the project with lint and assign it to me. and I will work on that after I put this PR about the makefile