Skip to content

Links containing search params are reported as broken #595

Open
@maddsua

Description

@maddsua

Simple example: a link like /checkout?services=setup-cctv would be reported as broken. Fixing this should be pretty easy tho. Gotta check the code, and I'll probably create a MR for it

Activity

maddsua

maddsua commented on Mar 21, 2024

@maddsua
Author

Oh interesting, so what's broken in my case is a redirect. In fact, that /checkout page is not /checkout.html but at /checkout/index.html. But I don't feel like just slapping a regex replace on top of it, what actually fails is the file server, redirect just doesn't try to prevent it from happening and that's why adding that regex replace fixed it for me

maddsua

maddsua commented on Mar 24, 2024

@maddsua
Author

So, I made a PR that fixes the issue: #596
I mean, I get that you're probably busy with more important things, but it would be nice to get this one done

maddsua

maddsua commented on Apr 5, 2024

@maddsua
Author

Hey @JustinBeckwith, don't want to be annoying or anything but I think that fixing this thing is kinda important

maddsua

maddsua commented on Jun 24, 2024

@maddsua
Author

Hi again! Is there any chance this fix will be merged anytime soon?
I mean, it breaks a few of my apps and I would hate to switch to a different link checker just because of that 😂
@JustinBeckwith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @JustinBeckwith@maddsua

        Issue actions

          Links containing search params are reported as broken · Issue #595 · JustinBeckwith/linkinator