Polish equality delete test #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make asserts more explicit by using assert_batches_eq! and reload the table prior to applying equality deletes.
gruuya
commented
Jul 9, 2025
| .await | ||
| .expect("Failed to create plan for select") | ||
| .collect() | ||
| .await | ||
| .expect("Failed to execute select query"); | ||
|
|
||
| for batch in batches { | ||
| if batch.num_rows() != 0 { |
There was a problem hiding this comment.
Without the table load above, the equality deletes are applied on top of the initial snapshot (without any rows), and so the end result is that there are no rows in the new snapshot either. Consequently the below assertions were never triggered.
There was a problem hiding this comment.
Great catch! The assert_batch makes this much better than before.
|
This is great! Makes the tests much more reliable. Thanks a lot for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make asserts more explicit by using
assert_batches_eq!.Also reload the table prior to applying equality deletes, otherwise the deletes are applied to an empty table (the initial snapshot prior to INSERT-ing the data), which was obfuscated by the existing assertion.