feat: vend credentials when loading a tabular #187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruuya
commented
Jun 4, 2025
Comment on lines
625
to
629
| // Enrich credentials with other options that might only be found in the config (e.g. | ||
| // a custom endpoint) | ||
| let mut options = (&credentials[0].config).clone(); | ||
| options.extend(config.clone()); | ||
| options |
There was a problem hiding this comment.
In the particular case of Lakekeeper, response.storage_credentials[0].config contains only AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and AWS_SESSION_TOKEN.
OTOH, response.config contains those as well, but then in addition it also has things like CLIENT_REGION, AWS_REGION, AWS_ENDPOINT, etc.
gruuya
force-pushed
the
load-tabular-vended-creds
branch
from
c98267d to
9c86504
Compare
|
Closing in favor of #188, which also adds parsing for GCS options and some tests too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a table/view make sure to pass the
vended-credentialsheader, so that the catalog server returns proper options for accessing the object store. Note that this is also the default in pyiceberg https://github.com/apache/iceberg-python/blob/a67c5592f3243d255519581fedfcc5d93274b9c8/pyiceberg/catalog/rest/__init__.py#L463In addition parse a couple more options, such as
s3.endpointwhen creating the object store.