Skip to content

fix(llc): fixes in the muteUsers api calls #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Jul 15, 2025

part of FLU-201

Summary by CodeRabbit

  • New Features

    • Added the ability to mute all users for a specific track type (audio, video, or all) during calls, providing more granular control over muting options.
  • Documentation

    • Updated descriptions to clarify the default behavior and new options available when muting users.
  • Bug Fixes

    • Fixed an issue with muting all tracks that improved reliability when muting all users.

Copy link

coderabbitai bot commented Jul 15, 2025

Walkthrough

The mute functionality in the call system was updated to allow specifying which type of track (audio, video, or all) to mute for all users. Both the Call and PermissionsManager classes now accept an optional track parameter in their muteAllUsers methods, enabling more granular control over muting behavior. Additionally, the muteOthers method was adjusted to include participants with any published tracks when muting all track types.

Changes

File(s) Change Summary
packages/stream_video/lib/src/call/call.dart Updated muteAllUsers to accept optional track parameter; improved documentation; forwards parameter.
packages/stream_video/lib/src/call/permissions/permissions_manager.dart Updated muteAllUsers and muteOthers to support selective track muting via track parameter; broadened participant selection when muting all tracks.
packages/stream_video/CHANGELOG.md Added a bug fix note for muteUsers method when called for all tracks.

Poem

In meetings where voices and faces abound,
Now rabbits can mute with more options around.
Audio, video, or everything at once—
Just pick your track, and silence ensues at once!
With a flick of a paw, control is more neat,
Muting’s now tailored, precise and complete.
🐰🔇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 056cd4c and b4b5f80.

📒 Files selected for processing (1)
  • packages/stream_video/CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/stream_video/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: build
  • GitHub Check: analyze
  • GitHub Check: stream_video_noise_cancellation
  • GitHub Check: stream_video
  • GitHub Check: stream_video_flutter
  • GitHub Check: stream_video_screen_sharing
  • GitHub Check: stream_video_push_notification
  • GitHub Check: analyze_legacy_version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 4.40%. Comparing base (7b782aa) to head (b4b5f80).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../lib/src/call/permissions/permissions_manager.dart 0.00% 6 Missing ⚠️
packages/stream_video/lib/src/call/call.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1026      +/-   ##
========================================
- Coverage   4.40%   4.40%   -0.01%     
========================================
  Files        574     574              
  Lines      38589   38593       +4     
========================================
  Hits        1700    1700              
- Misses     36889   36893       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Brazol Brazol marked this pull request as ready for review July 17, 2025 14:21
@Brazol Brazol requested a review from a team as a code owner July 17, 2025 14:21
Brazol and others added 3 commits July 17, 2025 16:21
…tream-video-flutter into fix/fixes-for-mute-users-api

# Conflicts:
#	packages/stream_video/CHANGELOG.md
@Brazol Brazol merged commit c9a01cf into main Jul 17, 2025
16 of 17 checks passed
@Brazol Brazol deleted the fix/fixes-for-mute-users-api branch July 17, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants